fix: static analysis errors (#89)

* fix: static analysis errors

* fix: coding standards

* fix: static analysis errors

* fix: static analysis errors

* fix: static analysis errors

* fix: coding standards

* fix: coding standards

* fix: static analysis errors

Author: millnut

localgov_forms.tokens.inc

@@ -7,6 +7,7 @@
 
 declare(strict_types=1);
 
+use Drupal\Core\Datetime\Entity\DateFormat;
 use Drupal\Core\Render\BubbleableMetadata;
 use Drupal\webform\Utility\WebformDateHelper;
 

modules/localgov_forms_example_liberty_create_integration/localgov_forms_example_liberty_create_integration.module

@@ -22,7 +22,7 @@ use Drupal\webform\WebformSubmissionInterface;
  */
 function localgov_forms_example_liberty_create_integration_modules_installed($modules, $is_syncing) {
 
-  if (!$is_syncing && in_array('token_environment', $modules)) {
+  if (!$is_syncing && in_array('token_environment', $modules, TRUE)) {
     $token_env_config   = Drupal::service('config.factory')->getEditable('token_environment.settings');
     $allowed_env_vars   = $token_env_config->get('allowed_env_variables') ?? [];
     $allowed_env_vars[] = 'DRUPAL_LIBERTY_CREATE_API_AUTH_KEY';
@@ -124,7 +124,7 @@ function localgov_forms_example_liberty_create_integration_webform_handler_invok
 function _localgov_forms_example_liberty_create_integration_manage_remote_post_custom_data(WebformHandlerInterface $handler) {
 
   $webform_submission = $handler->getWebformSubmission();
-  if (empty($webform_submission)) {
+  if (!$webform_submission instanceof WebformSubmissionInterface) {
     return;
   }
 

src/AddressLookup.php

@@ -102,18 +102,18 @@ public static function reformat(Location $addr) :array {
     }
 
     $address = [
-      'name'         => $unique_id ?? '',
-      'uprn'         => $uprn ?? '',
-      'display'      => $display_name ?? '',
+      'name'         => $unique_id,
+      'uprn'         => $uprn,
+      'display'      => $display_name,
       'street'       => implode(' ', array_filter([
         $street_number, $street_name,
       ])),
-      'flat'         => $flat ?? '',
+      'flat'         => $flat,
       'house'        => implode(', ', array_filter([$org, $house_name])),
       'town'         => $locality ?? '',
       'postcode'     => $postcode ?? '',
-      'lat'          => $latitude ?? '',
-      'lng'          => $longitude ?? '',
+      'lat'          => $latitude ?: '',
+      'lng'          => $longitude ?: '',
       'country'      => $country_name ?? '',
       'country_code' => $country_code ?? '',
       'line1'        => '',

src/Element/AddressLookupElement.php

@@ -198,7 +198,7 @@ public static function processAddressLookupElement(&$element, FormStateInterface
           $element['address_select']['address_select_list']['#disabled'] = FALSE;
           $options = array_keys($element['address_select']['address_select_list']['#options']);
           $selected = $parent_container_values['address_select']['address_select_list'] ?? 0;
-          if (!in_array($selected, $options)) {
+          if (!in_array($selected, $options, TRUE)) {
             $element['address_select']['address_select_list']['#value'] = NULL;
           }
         }
@@ -267,6 +267,13 @@ public static function valueCallback(&$element, $input, FormStateInterface $form
     if (empty($input['address_search']['address_searchstring'])) {
       return NULL;
     }
+
+    // FIXME: Call to method valueCallback() of deprecated class
+    // Drupal\Core\Render\Element\FormElement: in drupal:10.3.0 and
+    // is removed from drupal:12.0.0.
+    // use \Drupal\Core\Render\Element\FormElementBase instead.
+    // @phpstan-ignore-next-line
+    return parent::valueCallback($element, $input, $form_state);
   }
 
   /**