Address lookup does not populate address in localgov_scarfolk / base

[andybroomfield]

Encountering an error whilst testing the address lookup on a clean install.
When using localgov_scarfolk (and I assume the same would happen on localgov_base) the address lookup element does not populate the found addresses. I do get found address when I use Olivero so this might be a theme issue.

localgov.address.lookup.scarfolk.no.addresses.mp4

[Adnan-cds]

Hi Andy,
I see a Javascript console error symbol in the screencast above. Could you please check that error. This screencast has been very useful by the way.

[andybroomfield]

@Adnan-cds I think thats an extension (WGAG colour checker so not releated).

Issue is also present without the extension with no console error.

[Adnan-cds]

Okay, thanks. I will check.

[Adnan-cds]

This is breaking address lookup on localgov_base. I have a feeling there is a typo in the relevant code.

This ...

if ($id == 'edit-actions') {
  $id .= '--' . Crypt::randomBytesBase64(8);
}
$variables['attributes']['id'] = $id;
$variables['attributes']['data-drupal-selector'] = $id;
$variables['element']['#attributes']['data-drupal-selector'] = $id;
$variables['element']['#id'] = $id;

... may intended to look like

if ($id == 'edit-actions') {
  $id .= '--' . Crypt::randomBytesBase64(8);

  $variables['attributes']['id'] = $id;
  $variables['attributes']['data-drupal-selector'] = $id;
  $variables['element']['#attributes']['data-drupal-selector'] = $id;
  $variables['element']['#id'] = $id;
}

Copying Mark and Maria to confirm @markconroy @msayoung

[msayoung]

Here's the original issue we were trying to fix with that: https://www.drupal.org/project/drupal/issues/1852090
i suspect the address lookup field doesn't appreciate a random string.

I'll have to dig in to my memory of where the original problem was.

[andybroomfield]

This is now fixed in Localgov_base