Fix some es lint issues with npx eslint@8 --ext .js --resolve-plugins… (#215)

* Fix some es lint issues with npx eslint@8 --ext .js --resolve-plugins-relative-to=./web/core --fix web/modules/contrib/localgov_paragraphs/

* Fix es lint styleline errors with npx stylelint --ignore-path web/core/.stylelintignore --config web/core/.stylelintrc.json --fix web/modules/contrib/localgov_paragraphs/**/*.css

* Fix css with stylelint and js with eslint.

* Refactor localgov-accordion.js to address eslint errors.

* Remove old compiled localgov-tabs.js and rename localgov-tabs.es6.js to localgov-tabs.js.

* Refactor localgov-accordion.js to fix eslint errors.

* Refactor localgov-accordion.js based on feedback from @ruperj :)

* Use commit from offic_hours dev branch to fix failing phpunit test.

* Pin office_hours to 27be616c to address php failures.

* revert: office hours back to release tag

---------

Co-authored-by: Lee Mills <8024370+millnut@users.noreply.github.com>

Author: finnlewis

modules/localgov_paragraphs_layout/layouts/fourcol/fourcol_25_25_25_25/fourcol-25-25-25-25.css

@@ -5,6 +5,7 @@
 
 .layout--fourcol-25-25-25-25 {
   --lgd-page-section-gap: 0;
+
   display: grid;
   grid-template-columns: 1fr;
   gap: var(--lgd-page-section-gap);

modules/localgov_paragraphs_layout/layouts/threecol_33_34_33/threecol_33_34_33.css

@@ -5,6 +5,7 @@
 
 .layout--threecol-33-34-33 {
   --lgd-page-section-gap: 0;
+
   display: grid;
   grid-template-columns: 1fr;
   gap: var(--lgd-page-section-gap);
@@ -16,7 +17,7 @@
 }
 
 @media screen and (min-width: 40em) {
-  .layout--threecol-33-34-33  {
+  .layout--threecol-33-34-33 {
     /*
       If you need to add some gap between items here, you can set the
       --lgd-page-section-gap variable to whatever gap size you need.

modules/localgov_paragraphs_layout/layouts/twocol/twocol.css

@@ -5,6 +5,7 @@
 
 .layout--twocol {
   --lgd-page-section-gap: 0;
+
   display: grid;
   grid-template-columns: 1fr;
   gap: var(--lgd-page-section-gap);

modules/localgov_subsites_paragraphs/css/localgov-accordion.css

@@ -9,7 +9,7 @@
 }
 
 .accordion-pane__title button[hidden] {
-	display: none;
+  display: none;
 }
 
 .accordion--initialised .accordion-pane__content {

modules/localgov_subsites_paragraphs/css/localgov-box-links-listing.css

@@ -10,9 +10,9 @@
 
 /* 'Grid' theme. */
 .box-links-listing--grid .box-links-listing__list-item {
-  border: 1px solid #f2f2f2;
   margin: 0 -1px -1px 0;
   padding: 20px;
+  border: 1px solid #f2f2f2;
 }
 
 /* 'Boxes' theme. */

modules/localgov_subsites_paragraphs/css/localgov-media-with-text.css

@@ -4,8 +4,8 @@
  */
 
 .media-with-text--featured {
-  background-color: #fafafa;
   border: 1px solid #ccc;
+  background-color: #fafafa;
 }
 
 .media-with-text--featured .media-with-text__body {
@@ -45,7 +45,7 @@
 
 .media-with-text--media-left .media-with-text__body,
 .media-with-text--media-right .media-with-text__body {
-  width: 100%
+  width: 100%;
 }
 
 .media-with-text--media-left .media-with-text__body {

modules/localgov_subsites_paragraphs/css/localgov-subsites-paragraphs.css

@@ -12,19 +12,19 @@
   padding-right: 5px;
 }
 .paragraph--type--page-section .layout--threecol-33-34-33 .layout__region--second {
-  padding-left: 5px;
   padding-right: 5px;
+  padding-left: 5px;
 }
 .paragraph--type--page-section .layout--threecol-33-34-33 .layout__region--third {
   padding-left: 5px;
 }
 
 /* Call out box */
 .call-out-box {
-  background-position: center;
+  padding: 10px;
   background-repeat: no-repeat;
+  background-position: center;
   background-size: cover;
-  padding: 10px;
 }
 
 /* Fact box */
@@ -34,4 +34,3 @@
 .fact-box p {
   text-align: center;
 }
-

modules/localgov_subsites_paragraphs/css/localgov-tabs.css

@@ -4,29 +4,29 @@
 }
 
 .tabs--initialised .tab-panel--active {
-  border: 1px solid #ddd;
   display: block;
+  border: 1px solid #ddd;
 }
 
 .tabs--initialised .tabs__controls {
   display: flex;
-  list-style: none;
   margin: 0;
   padding: 0;
+  list-style: none;
 }
 
 .tabs--initialised .tabs__controls li {
   margin: 0;
 }
 
 .tabs--initialised .tabs__controls button {
-  background: #eee;
-  border: 1px solid #ddd;
   position: relative;
   top: 1px;
+  border: 1px solid #ddd;
+  background: #eee;
 }
 
 .tabs--initialised .tabs__controls [aria-selected="true"] {
-  background-color: #fff;
   border-bottom-color: #fff;
+  background-color: #fff;
 }