Skip to content

Commit 2a295c0

Browse files
address comments
1 parent dd8c93b commit 2a295c0

File tree

5 files changed

+83
-74
lines changed

5 files changed

+83
-74
lines changed

.github/workflows/build.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,14 @@ jobs:
4343
- name: Install dependencies
4444
run: npm ci
4545

46+
- name: Type check
47+
run: npx tsc
48+
49+
- name: Compile
50+
run: npx vsce package
51+
4652
- name: Test
47-
run: make test
53+
run: xvfb-run -a make test
4854
env:
4955
LOCALSTACK_WEB_AUTH_REDIRECT: https://app.localstack.cloud/redirect?name=VSCode
5056
NODE_ENV: ci

.github/workflows/publish-ovsx.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/publish-vs-marketplace.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/publish.yml

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
name: Publish Extension
2+
3+
on:
4+
workflow_dispatch:
5+
inputs:
6+
publish_vscode_marketplace:
7+
description: 'Publish to VS Marketplace'
8+
type: boolean
9+
default: true
10+
publish_ovsx:
11+
description: 'Publish to Open VSX'
12+
type: boolean
13+
default: true
14+
15+
permissions:
16+
contents: read
17+
18+
jobs:
19+
publish-vscode-marketplace:
20+
name: Publish to VS Marketplace
21+
runs-on: ubuntu-latest
22+
if: ${{ inputs.publish_vscode_marketplace != false }}
23+
24+
steps:
25+
- name: Checkout
26+
uses: actions/checkout@v5
27+
28+
- name: Setup Node
29+
uses: actions/setup-node@v4
30+
with:
31+
cache: npm
32+
33+
- name: Install dependencies
34+
run: npm ci
35+
36+
- name: Set version from branch name
37+
uses: ./.github/actions/set-version
38+
39+
- name: Publish to VS Marketplace
40+
run: make publish-marketplace
41+
env:
42+
VERSION: ${{ env.VERSION }}
43+
VSCE_PAT: ${{ secrets.VSCE_PAT }}
44+
LOCALSTACK_WEB_AUTH_REDIRECT: https://app.localstack.cloud/redirect?name=VSCode
45+
NODE_ENV: production
46+
ANALYTICS_API_URL: https://analytics.localstack.cloud/v1/events
47+
48+
publish-ovsx:
49+
name: Publish to Open VSX
50+
runs-on: ubuntu-latest
51+
if: ${{ inputs.publish_ovsx != false }}
52+
53+
steps:
54+
- name: Checkout
55+
uses: actions/checkout@v5
56+
57+
- name: Setup Node
58+
uses: actions/setup-node@v4
59+
with:
60+
cache: npm
61+
62+
- name: Install dependencies
63+
run: npm ci
64+
65+
- name: Set version from branch name
66+
uses: ./.github/actions/set-version
67+
68+
- name: Publish to Open VSX
69+
run: make publish-ovsx
70+
env:
71+
VERSION: ${{ env.VERSION }}
72+
OVSX_PAT: ${{ secrets.OVSX_PAT }}
73+
LOCALSTACK_WEB_AUTH_REDIRECT: https://app.localstack.cloud/redirect?name=VSCode
74+
NODE_ENV: production
75+
ANALYTICS_API_URL: https://analytics.localstack.cloud/v1/events

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ test:
1515
@echo "Compiling extension..."
1616
npx vsce package
1717
@echo "Running tests..."
18-
xvfb-run -a npx vscode-test
18+
npx vscode-test
1919

2020
publish-marketplace:
2121
@echo "Publishing VS Code extension to VS Marketplace..."

0 commit comments

Comments
 (0)