refactor

Author: skyrpex

src/plugins/manage.ts

@@ -20,7 +20,7 @@ export default createPlugin(
 			commands.registerCommand("localstack.start", async () => {
 				const cliPath = cliStatusTracker.cliPath();
 				if (!cliPath) {
-					window.showInformationMessage(
+					void window.showInformationMessage(
 						"LocalStack CLI could not be found. Please, run the setup wizard.",
 					);
 					return;
@@ -43,7 +43,7 @@ export default createPlugin(
 			commands.registerCommand("localstack.stop", () => {
 				const cliPath = cliStatusTracker.cliPath();
 				if (!cliPath) {
-					window.showInformationMessage(
+					void window.showInformationMessage(
 						"LocalStack CLI could not be found. Please, run the setup wizard.",
 					);
 					return;

src/plugins/setup.ts

@@ -45,12 +45,6 @@ export default createPlugin(
 					});
 
 					const cliPath = cliStatusTracker.cliPath();
-					if (!cliPath) {
-						void window.showErrorMessage(
-							"LocalStack CLI is not configured. Please set it up before running the setup wizard.",
-						);
-						return;
-					}
 
 					void window.withProgress(
 						{
@@ -65,7 +59,7 @@ export default createPlugin(
 							{
 								const installationStartedAt = new Date().toISOString();
 								const { cancelled, skipped } = await runInstallProcess({
-									cliPath,
+									cliPath: cliStatusTracker.cliPath(),
 									progress,
 									cancellationToken,
 									outputChannel,
@@ -231,6 +225,14 @@ export default createPlugin(
 							/////////////////////////////////////////////////////////////////////
 							progress.report({ message: "Checking LocalStack license..." });
 
+							const cliPath = cliStatusTracker.cliPath();
+							if (!cliPath) {
+								void window.showErrorMessage(
+									"LocalStack CLI is not configured. Please set it up before running the setup wizard.",
+								);
+								return;
+							}
+
 							// If an auth token has just been obtained or LocalStack has never been started,
 							// then there will be no license info to be reported by `localstack license info`.
 							// Also, an expired license could be cached.

src/plugins/status-bar.ts

@@ -112,11 +112,8 @@ export default createPlugin(
 			statusBarItem.text = `${icon} LocalStack: ${statusText}`;
 
 			statusBarItem.tooltip = "Show LocalStack commands";
-			// statusBarItem.show();
 		});
 
-		// refreshStatusBar();
-
 		localStackStatusTracker.onChange(() => {
 			outputChannel.trace("[status-bar]: localStackStatusTracker changed");
 			renderStatusBar();