chore: enable object-shorthand eslint rule (#44)

ECMAScript 6 provides a concise form for defining object literal methods
and properties. This syntax can make defining complex object literals
much cleaner.

Author: skyrpex

.node-version

@@ -0,0 +1 @@
+24

eslint.config.mjs

@@ -1,13 +1,25 @@
 import { fileURLToPath, URL } from "node:url";
 
 import { includeIgnoreFile } from "@eslint/compat";
+import { defineConfig } from "eslint/config";
 import importPlugin from "eslint-plugin-import";
 import tseslint from "typescript-eslint";
 
-export default tseslint.config(
+export default defineConfig(
 	includeIgnoreFile(fileURLToPath(new URL(".gitignore", import.meta.url))),
 	{
-		extends: [tseslint.configs.recommendedTypeChecked],
+		rules: {
+			"object-shorthand": ["error", "always"],
+		},
+	},
+	{
+		extends: [
+			// Base recommended rules from @typescript-eslint.
+			tseslint.configs.recommendedTypeChecked,
+			// In the future, we might want to switch to more strict configs.
+			// tseslint.configs.strictTypeChecked,
+			// tseslint.configs.stylisticTypeChecked,
+		],
 		languageOptions: {
 			parserOptions: {
 				projectService: true,

src/plugins/configure-aws.ts

@@ -9,7 +9,7 @@ export default createPlugin(
 		context.subscriptions.push(
 			commands.registerCommand("localstack.configureAwsProfiles", async () => {
 				await configureAwsProfiles({
-					telemetry: telemetry,
+					telemetry,
 					notifyNoChangesMade: true,
 					outputChannel,
 				});

src/plugins/setup.ts

@@ -224,7 +224,7 @@ export default createPlugin(
 							});
 							await minDelay(
 								configureAwsProfiles({
-									telemetry: telemetry,
+									telemetry,
 									origin: origin_trigger,
 								}),
 							);

src/utils/setup.ts

@@ -82,7 +82,7 @@ async function pullDockerImage(
 		await spawn("docker", ["pull", LOCALSTACK_DOCKER_IMAGE_NAME], {
 			outputChannel,
 			outputLabel: "docker.pull",
-			cancellationToken: cancellationToken,
+			cancellationToken,
 		});
 	} catch (error) {
 		outputChannel.error("Could not pull LocalStack docker image");