Skip to content

Commit 906f37f

Browse files
committed
Consistency: track setup_ended for cancelled events
1 parent 146cbd4 commit 906f37f

File tree

2 files changed

+243
-80
lines changed

2 files changed

+243
-80
lines changed

src/plugins/setup.ts

Lines changed: 32 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,13 @@ import {
1616
} from "../utils/license.ts";
1717
import { minDelay } from "../utils/promises.ts";
1818
import { updateDockerImage } from "../utils/setup.ts";
19+
import {
20+
get_setup_ended_on_image_prefetch_cancelled,
21+
get_setup_ended_on_authentication_cancelled,
22+
get_setup_ended_on_cli_setup_cancelled,
23+
get_setup_ended_on_license_setup_cancelled,
24+
get_setup_ended_completed,
25+
} from "../utils/telemetry.ts";
1926

2027
export default createPlugin(
2128
"setup",
@@ -71,6 +78,7 @@ export default createPlugin(
7178
status: "CANCELLED",
7279
},
7380
});
81+
telemetry.track(get_setup_ended_on_cli_setup_cancelled());
7482
return;
7583
}
7684
}
@@ -91,43 +99,17 @@ export default createPlugin(
9199
const authenticated = await minDelay(checkIsAuthenticated());
92100
if (cancellationToken.isCancellationRequested) {
93101
telemetry.track({
94-
name: "setup_ended",
102+
name: "auth_token_configured",
95103
payload: {
96104
namespace: "onboarding",
97-
steps: [
98-
{
99-
name: "emulator_installed",
100-
is_first_step: true,
101-
is_last_step: false,
102-
step_order: 1,
103-
status: "COMPLETED",
104-
},
105-
{
106-
name: "auth_token_configured",
107-
is_first_step: false,
108-
is_last_step: false,
109-
step_order: 2,
110-
status: "CANCELLED",
111-
},
112-
{
113-
name: "license_setup_ended",
114-
is_first_step: false,
115-
is_last_step: false,
116-
step_order: 3,
117-
status: "SKIPPED",
118-
},
119-
{
120-
name: "aws_profile_configured",
121-
is_first_step: false,
122-
is_last_step: true,
123-
step_order: 4,
124-
status: "SKIPPED",
125-
},
126-
],
105+
origin: origin_trigger,
106+
step_order: 2,
107+
started_at: authStartedAuthAt,
108+
ended_at: new Date().toISOString(),
127109
status: "CANCELLED",
128-
auth_token: await readAuthToken(),
129110
},
130111
});
112+
telemetry.track(get_setup_ended_on_authentication_cancelled());
131113
return;
132114
}
133115
if (authenticated) {
@@ -145,6 +127,7 @@ export default createPlugin(
145127
status: "SKIPPED",
146128
},
147129
});
130+
148131
await minDelay(Promise.resolve());
149132
} else {
150133
/////////////////////////////////////////////////////////////////////
@@ -171,6 +154,9 @@ export default createPlugin(
171154
status: "CANCELLED",
172155
},
173156
});
157+
telemetry.track(
158+
get_setup_ended_on_authentication_cancelled(),
159+
);
174160
return;
175161
}
176162

@@ -192,7 +178,9 @@ export default createPlugin(
192178
status: "CANCELLED",
193179
},
194180
});
195-
181+
telemetry.track(
182+
get_setup_ended_on_authentication_cancelled(authToken),
183+
);
196184
return;
197185
}
198186
}
@@ -237,6 +225,11 @@ export default createPlugin(
237225
status: "CANCELLED",
238226
},
239227
});
228+
telemetry.track(
229+
get_setup_ended_on_license_setup_cancelled(
230+
await readAuthToken(),
231+
),
232+
);
240233
return;
241234
}
242235

@@ -279,14 +272,11 @@ export default createPlugin(
279272
}
280273

281274
if (cancellationToken.isCancellationRequested) {
282-
telemetry.track({
283-
name: "setup_ended",
284-
payload: {
285-
namespace: "onboarding",
286-
steps: [1, 2, 3],
287-
status: "CANCELLED",
288-
},
289-
});
275+
telemetry.track(
276+
get_setup_ended_on_image_prefetch_cancelled(
277+
await readAuthToken(),
278+
),
279+
);
290280
return;
291281
}
292282

@@ -315,44 +305,7 @@ export default createPlugin(
315305
});
316306
}
317307

318-
telemetry.track({
319-
name: "setup_ended",
320-
payload: {
321-
namespace: "onboarding",
322-
steps: [
323-
{
324-
name: "emulator_installed",
325-
is_first_step: true,
326-
is_last_step: false,
327-
step_order: 1,
328-
status: "COMPLETED",
329-
},
330-
{
331-
name: "auth_token_configured",
332-
is_first_step: false,
333-
is_last_step: false,
334-
step_order: 2,
335-
status: "COMPLETED",
336-
},
337-
{
338-
name: "license_setup_ended",
339-
is_first_step: false,
340-
is_last_step: false,
341-
step_order: 3,
342-
status: "COMPLETED",
343-
},
344-
{
345-
name: "aws_profile_configured",
346-
is_first_step: false,
347-
is_last_step: true,
348-
step_order: 4,
349-
status: "COMPLETED",
350-
},
351-
],
352-
status: "COMPLETED",
353-
auth_token: await readAuthToken(),
354-
},
355-
});
308+
telemetry.track(get_setup_ended_completed(await readAuthToken()));
356309
},
357310
);
358311
},

0 commit comments

Comments
 (0)