From b4a5f272aab3aae9223cf67360e092c8a3e0c189 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 9 Sep 2025 09:55:02 +0200 Subject: [PATCH 1/5] chore: enable `object-shorthand` eslint rule ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner. --- eslint.config.mjs | 13 ++++++++++++- src/plugins/configure-aws.ts | 2 +- src/utils/setup.ts | 2 +- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index f4cf933..0e705b9 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -7,7 +7,18 @@ import tseslint from "typescript-eslint"; export default tseslint.config( includeIgnoreFile(fileURLToPath(new URL(".gitignore", import.meta.url))), { - extends: [tseslint.configs.recommendedTypeChecked], + rules: { + "object-shorthand": ["error", "always"], + } + }, + { + extends: [ + // Base recommended rules from @typescript-eslint. + tseslint.configs.recommendedTypeChecked, + // In the future, we might want to switch to more strict configs. + // tseslint.configs.strictTypeChecked, + // tseslint.configs.stylisticTypeChecked, + ], languageOptions: { parserOptions: { projectService: true, diff --git a/src/plugins/configure-aws.ts b/src/plugins/configure-aws.ts index cbcc21d..f4ab956 100644 --- a/src/plugins/configure-aws.ts +++ b/src/plugins/configure-aws.ts @@ -9,7 +9,7 @@ export default createPlugin( context.subscriptions.push( commands.registerCommand("localstack.configureAwsProfiles", async () => { await configureAwsProfiles({ - telemetry: telemetry, + telemetry, notifyNoChangesMade: true, outputChannel, }); diff --git a/src/utils/setup.ts b/src/utils/setup.ts index 7589003..0c1c3dc 100644 --- a/src/utils/setup.ts +++ b/src/utils/setup.ts @@ -82,7 +82,7 @@ async function pullDockerImage( await spawn("docker", ["pull", LOCALSTACK_DOCKER_IMAGE_NAME], { outputChannel, outputLabel: "docker.pull", - cancellationToken: cancellationToken, + cancellationToken, }); } catch (error) { outputChannel.error("Could not pull LocalStack docker image"); From 9056dc294395a42fc12fd364dfa4201a72832ee8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 9 Sep 2025 10:08:44 +0200 Subject: [PATCH 2/5] update deprecated method --- eslint.config.mjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index 0e705b9..55d9502 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -1,10 +1,11 @@ import { fileURLToPath, URL } from "node:url"; import { includeIgnoreFile } from "@eslint/compat"; +import { defineConfig } from "eslint/config"; import importPlugin from "eslint-plugin-import"; import tseslint from "typescript-eslint"; -export default tseslint.config( +export default defineConfig( includeIgnoreFile(fileURLToPath(new URL(".gitignore", import.meta.url))), { rules: { From 444dfe749ebd893a4fcf7a8183cb1da5d73e212c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 9 Sep 2025 10:08:52 +0200 Subject: [PATCH 3/5] fix style --- eslint.config.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index 55d9502..a48779d 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -10,7 +10,7 @@ export default defineConfig( { rules: { "object-shorthand": ["error", "always"], - } + }, }, { extends: [ From 1d5fb4b75d51db3e5da281d93dd1f12a481b4646 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 9 Sep 2025 10:09:00 +0200 Subject: [PATCH 4/5] suggest node version --- .node-version | 1 + 1 file changed, 1 insertion(+) create mode 100644 .node-version diff --git a/.node-version b/.node-version new file mode 100644 index 0000000..a45fd52 --- /dev/null +++ b/.node-version @@ -0,0 +1 @@ +24 From 38cf7d5a1bef6c67e1cf185c326978d6d7159f31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 9 Sep 2025 10:16:16 +0200 Subject: [PATCH 5/5] fix style --- src/plugins/setup.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/setup.ts b/src/plugins/setup.ts index 41d4fcd..16e4bdf 100644 --- a/src/plugins/setup.ts +++ b/src/plugins/setup.ts @@ -224,7 +224,7 @@ export default createPlugin( }); await minDelay( configureAwsProfiles({ - telemetry: telemetry, + telemetry, origin: origin_trigger, }), );