From 20e4b00a01fa5b3e5629a0eccbc2334418af2525 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 2 Sep 2025 17:17:26 +0200 Subject: [PATCH 1/2] chore: silence false positives for biome rule `lint/style/noNonNullAssertion` --- src/utils/authenticate.ts | 1 + src/utils/container-status.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/utils/authenticate.ts b/src/utils/authenticate.ts index a125a75..24eb5d3 100644 --- a/src/utils/authenticate.ts +++ b/src/utils/authenticate.ts @@ -60,6 +60,7 @@ async function redirectToLocalStack() { ); const redirectSearchParams = new URLSearchParams(redirectUri.query); + // biome-ignore lint/style/noNonNullAssertion: false positive const url = new URL(process.env.LOCALSTACK_WEB_AUTH_REDIRECT!); url.searchParams.set("windowId", redirectSearchParams.get("windowId") ?? ""); diff --git a/src/utils/container-status.ts b/src/utils/container-status.ts index 782323a..d70e1f4 100644 --- a/src/utils/container-status.ts +++ b/src/utils/container-status.ts @@ -40,6 +40,7 @@ export async function createContainerStatusTracker( return { status() { + // biome-ignore lint/style/noNonNullAssertion: false positive return status!; }, onChange(callback) { From 932eb04a720f83aa01236f24d4ac72500b6b00f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Pallar=C3=A9s?= Date: Tue, 2 Sep 2025 17:23:03 +0200 Subject: [PATCH 2/2] wip --- src/utils/authenticate.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils/authenticate.ts b/src/utils/authenticate.ts index 24eb5d3..a53abcc 100644 --- a/src/utils/authenticate.ts +++ b/src/utils/authenticate.ts @@ -60,6 +60,7 @@ async function redirectToLocalStack() { ); const redirectSearchParams = new URLSearchParams(redirectUri.query); + // TODO: Gather environment variables in a safer way - e.g. during extension activation // biome-ignore lint/style/noNonNullAssertion: false positive const url = new URL(process.env.LOCALSTACK_WEB_AUTH_REDIRECT!); url.searchParams.set("windowId", redirectSearchParams.get("windowId") ?? "");