Handle null URI scheme in RasterSource

Signed-off-by: Jason T. Brown <[email protected]>

Author: vpipkt

core/src/main/scala/org/locationtech/rasterframes/ref/RasterSource.scala

@@ -129,13 +129,18 @@ object RasterSource extends LazyLogging {
       } else false
 
     /** Extractor for determining if a scheme indicates GDAL preference.  */
-    def unapply(source: URI): Boolean =
-      gdalOnly(source) || ((preferGdal || source.getScheme.startsWith("gdal")) && GDALRasterSource.hasGDAL)
+    def unapply(source: URI): Boolean = {
+      lazy val schemeIsGdal = Option(source.getScheme())
+        .exists(_.startsWith("gdal"))
+
+      gdalOnly(source) || ((preferGdal || schemeIsGdal) && GDALRasterSource.hasGDAL)
+    }
   }
 
   object IsDefaultGeoTiff {
     def unapply(source: URI): Boolean = source.getScheme match {
-      case "file" | "http" | "https" | "s3" | "" => true
+      case "file" | "http" | "https" | "s3" => true
+      case null | ""                        ⇒ true
       case _                                => false
     }
   }

core/src/test/scala/org/locationtech/rasterframes/ref/RasterSourceSpec.scala

@@ -109,6 +109,7 @@ class RasterSourceSpec extends TestEnvironment with TestData {
     it("should interpret no scheme as file://"){
       val localSrc = geotiffDir.resolve("LC08_B7_Memphis_COG.tiff").toString()
       val schemelessUri = new URI(localSrc)
+      schemelessUri.getScheme should be (null)
       val src = RasterSource(schemelessUri)
       assert(!src.extent.isEmpty)
     }
@@ -138,6 +139,15 @@ class RasterSourceSpec extends TestEnvironment with TestData {
 
         gdal.bandCount should be (3)
       }
+
+      it("should interpret no scheme as file://") {
+        val localSrc = geotiffDir.resolve("LC08_B7_Memphis_COG.tiff").toString()
+        val schemelessUri = new URI(localSrc)
+        val gdal = GDALRasterSource(schemelessUri)
+        val jvm = JVMGeoTiffRasterSource(schemelessUri)
+        gdal.extent should be (jvm.extent)
+        gdal.cellSize should be(jvm.cellSize)
+      }
     }
   }