Fix v14 related stuff

Author: lochmueller

Classes/Cache/RemoteFileBackend.php

@@ -20,6 +20,9 @@
  */
 class RemoteFileBackend extends AbstractBackend implements TaggableBackendInterface, TransientBackendInterface
 {
+    public const DATETIME_EXPIRYTIME_UNLIMITED_INTERNAL = '9999-12-31T23:59:59+0000';
+    public const UNLIMITED_LIFETIME_INTERNAL = 0;
+
     /**
      * Relative folder name.
      */
@@ -93,7 +96,7 @@ public function set($entryIdentifier, $data, array $tags = [], $lifetime = null)
         }
 
         GeneralUtility::writeFile($absoluteCacheDir . $fileName . self::FILE_EXTENSION_TAG, '|' . implode('|', $tags) . '|');
-        GeneralUtility::writeFile($absoluteCacheDir . $fileName . self::FILE_EXTENSION_LIFETIME, (string) $this->calculateExpiryTime($lifetime)->getTimestamp());
+        GeneralUtility::writeFile($absoluteCacheDir . $fileName . self::FILE_EXTENSION_LIFETIME, (string) $this->calculateExpiryTimeInternal($lifetime)->getTimestamp());
         GeneralUtility::writeFile($absoluteCacheDir . $fileName . self::FILE_EXTENSION_IDENTIFIER, $entryIdentifier);
     }
 
@@ -262,12 +265,15 @@ protected function getFileName(string $entryIdentifier): string
         try {
             if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 14) {
                 /** @var ResourceFactory $resourceFactory */
+                // @phpstan-ignore-next-line
                 $resourceFactory = GeneralUtility::makeInstance(ResourceFactory::class);
             } else {
                 /** @var StorageRepository $resourceFactory */
+                // @phpstan-ignore-next-line
                 $resourceFactory = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Resource\StorageRepository::class);
             }
 
+            // @phpstan-ignore-next-line
             $storage = $resourceFactory->getDefaultStorage();
             $baseName = (string) $storage->sanitizeFileName($baseName);
         } catch (\Exception $exception) {
@@ -287,4 +293,20 @@ public function flushByTags(array $tags): void
             $this->flushByTag($tag);
         }
     }
+
+    /**
+     * @see https://github.com/TYPO3/typo3/blob/13.4/typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php#L138 (method do not exists in v14 anymore)
+     */
+    protected function calculateExpiryTimeInternal($lifetime = null)
+    {
+        if ($lifetime === self::UNLIMITED_LIFETIME_INTERNAL || $lifetime === null && $this->defaultLifetime === self::UNLIMITED_LIFETIME_INTERNAL) {
+            $expiryTime = new \DateTime(self::DATETIME_EXPIRYTIME_UNLIMITED_INTERNAL, new \DateTimeZone('UTC'));
+        } else {
+            if ($lifetime === null) {
+                $lifetime = $this->defaultLifetime;
+            }
+            $expiryTime = new \DateTime('now +' . $lifetime . ' seconds', new \DateTimeZone('UTC'));
+        }
+        return $expiryTime;
+    }
 }

Classes/Cache/StaticFileBackend.php

@@ -237,8 +237,6 @@ protected function processQueueRefill(CacheRepository $cacheRepository, QueueRep
      */
     public function flushByTags(array $tags): void
     {
-        $this->throwExceptionIfFrontendDoesNotExist();
-
         if (empty($tags)) {
             return;
         }
@@ -275,8 +273,6 @@ public function flushByTags(array $tags): void
      */
     public function flushByTag($tag): void
     {
-        $this->throwExceptionIfFrontendDoesNotExist();
-
         $this->logger->debug('SFC flushByTags', [$tag]);
         $identifiers = $this->findIdentifiersByTagIncludingExpired($tag);
 
@@ -400,7 +396,6 @@ protected function findIdentifiersByTagsIncludingExpired(array $tags): array
      */
     public function findIdentifiersByTags(array $tags)
     {
-        $this->throwExceptionIfFrontendDoesNotExist();
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable($this->tagsTable);
         $result = $queryBuilder->select($this->cacheTable . '.identifier')

phpstan.neon

@@ -2,7 +2,7 @@ includes:
 	- phpstan-baseline.neon
 
 parameters:
-	level: 4
+	level: 5
 	reportUnmatchedIgnoredErrors: false
 	paths:
 		- Classes