Skip to content

Commit e4dd21f

Browse files
committed
First v14 caching
1 parent 2826cd9 commit e4dd21f

File tree

8 files changed

+8
-487
lines changed

8 files changed

+8
-487
lines changed

Classes/Cache/StaticFileBackend13.php

Lines changed: 0 additions & 475 deletions
This file was deleted.

Classes/Cache/UriFrontend.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function getByTag($tag)
4444
if (!$this->isValidTag($tag)) {
4545
throw new \InvalidArgumentException('"' . $tag . '" is not a valid tag for a cache entry.', 1233058312);
4646
}
47-
assert($this->backend instanceof TaggableBackendInterface);
47+
$this->backend instanceof TaggableBackendInterface or throw new \InvalidArgumentException('Backend is not taggable', 12389123);
4848
$entries = [];
4949
$identifiers = $this->backend->findIdentifiersByTag($tag);
5050
foreach ($identifiers as $identifier) {

Classes/Middleware/FrontendUserMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public function __construct(private CookieService $cookieService) {}
1919
public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
2020
{
2121
$feUser = $request->getAttribute('frontend.user');
22-
assert($feUser instanceof FrontendUserAuthentication);
22+
$feUser instanceof FrontendUserAuthentication or throw new \InvalidArgumentException('no frontend user attribite in the current request', 127389123);
2323

2424
$response = $handler->handle($request);
2525

Classes/Middleware/GenerateMiddleware.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use SFC\Staticfilecache\Service\DateTimeService;
2020
use TYPO3\CMS\Core\Http\ServerRequest;
2121
use TYPO3\CMS\Core\Information\Typo3Version;
22+
use TYPO3\CMS\Extbase\Utility\DebuggerUtility;
2223

2324
class GenerateMiddleware implements MiddlewareInterface
2425
{

Classes/Middleware/PrepareMiddleware.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use SFC\Staticfilecache\Service\ConfigurationService;
1616
use SFC\Staticfilecache\Service\HttpPushService;
1717
use SFC\Staticfilecache\Service\InlineAssetsService;
18+
use TYPO3\CMS\Extbase\Utility\DebuggerUtility;
1819

1920
class PrepareMiddleware implements MiddlewareInterface
2021
{

Configuration/RequestMiddlewares.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@
1414
'staticfilecache/prepare' => [
1515
'target' => PrepareMiddleware::class,
1616
'before' => [
17-
'typo3/cms-frontend/base-redirect-resolver',
17+
'typo3/cms-core/cache-timeout',
1818
],
1919
'after' => [
2020
'typo3/cms-frontend/site',
21+
'typo3/cms-frontend/page-resolver',
22+
'typo3/cms-frontend/prepare-tsfe-rendering', // We need frontend.page.information
2123
],
2224
],
2325
'staticfilecache/generate' => [

ext_localconf.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
use SFC\Staticfilecache\Cache\RemoteFileBackend;
66
use SFC\Staticfilecache\Cache\StaticFileBackend;
7-
use SFC\Staticfilecache\Cache\StaticFileBackend13;
87
use SFC\Staticfilecache\Cache\UriFrontend;
98
use SFC\Staticfilecache\Hook\DatamapHook;
109
use TYPO3\CMS\Core\Cache\Backend\NullBackend;
@@ -21,15 +20,11 @@
2120
$extensionConfig = (array)GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('staticfilecache');
2221
$useNullBackend = $extensionConfig['disableInDevelopment'] && Environment::getContext()->isDevelopment();
2322

24-
$staticFileBackendClass = StaticFileBackend::class;
25-
if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 14) {
26-
$staticFileBackendClass = StaticFileBackend13::class;
27-
}
2823

2924

3025
$GLOBALS['TYPO3_CONF_VARS']['SYS']['caching']['cacheConfigurations']['staticfilecache'] = [
3126
'frontend' => UriFrontend::class,
32-
'backend' => $useNullBackend ? NullBackend::class : $staticFileBackendClass,
27+
'backend' => $useNullBackend ? NullBackend::class : StaticFileBackend::class,
3328
'groups' => [
3429
'pages',
3530
'all',

phpstan.neon

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,3 @@ parameters:
44
paths:
55
- Classes
66
- Tests
7-
excludePaths:
8-
- Classes/Cache/StaticFileBackend.php
9-
- Classes/Cache/StaticFileBackend13.php

0 commit comments

Comments
 (0)