Get phpstand running

Author: lochmueller

Classes/Cache/RemoteFileBackend.php

@@ -105,7 +105,7 @@ public function set($entryIdentifier, $data, array $tags = [], $lifetime = null)
      *
      * @api
      */
-    public function get($entryIdentifier)
+    public function get(string $entryIdentifier): mixed
     {
         if (!$this->has($entryIdentifier)) {
             return false;
@@ -117,13 +117,9 @@ public function get($entryIdentifier)
     /**
      * Checks if a cache entry with the specified identifier exists.
      *
-     * @param string $entryIdentifier An identifier specifying the cache entry
-     *
-     * @return bool TRUE if such an entry exists, FALSE if not
-     *
      * @api
      */
-    public function has($entryIdentifier)
+    public function has(string $entryIdentifier): bool
     {
         $folder = GeneralUtility::getFileAbsFileName(self::RELATIVE_STORAGE_FOLDER);
         $fileName = $this->getFileName($entryIdentifier);
@@ -148,7 +144,7 @@ public function has($entryIdentifier)
      *
      * @api
      */
-    public function remove($entryIdentifier)
+    public function remove(string $entryIdentifier): bool
     {
         $folder = GeneralUtility::getFileAbsFileName(self::RELATIVE_STORAGE_FOLDER);
         $fileName = $this->getFileName($entryIdentifier);
@@ -228,7 +224,7 @@ public function flushByTag($tag): void
      *
      * @api
      */
-    public function findIdentifiersByTag($tag)
+    public function findIdentifiersByTag(string $tag): array
     {
         $tagsFiles = glob(GeneralUtility::getFileAbsFileName(self::RELATIVE_STORAGE_FOLDER) . '*/*/*' . self::FILE_EXTENSION_TAG);
         $identifiers = [];
@@ -276,4 +272,9 @@ protected function getFileName(string $entryIdentifier): string
 
         return $remoteStructure . '/' . $baseName;
     }
+
+    public function flushByTags(array $tags): void
+    {
+        // @todo check
+    }
 }

Classes/Cache/StaticDatabaseBackend.php

@@ -48,11 +48,9 @@ public function setCache(FrontendInterface $cache): void
     }
 
     /**
-     * Change the template to allow longer idenitifiers.
-     *
-     * @return string
+     * Change the template to allow longer identifiers.
      */
-    public function getTableDefinitions()
+    public function getTableDefinitions(): string
     {
         $large = $this->configuration->isBool('largeIdentifierInCacheTable') ? 'Large' : '';
 

Classes/Cache/StaticFileBackend.php

@@ -111,7 +111,7 @@ public function set($entryIdentifier, $data, array $tags = [], $lifetime = null)
      *
      * @return mixed The cache entry's content as a string or FALSE if the cache entry could not be loaded
      */
-    public function get($entryIdentifier)
+    public function get(string $entryIdentifier): mixed
     {
         if (!$this->has($entryIdentifier)) {
             return false;
@@ -131,7 +131,7 @@ public function get($entryIdentifier)
      *
      * @return bool TRUE if such an entry exists, FALSE if not
      */
-    public function has($entryIdentifier)
+    public function has(string $entryIdentifier): bool
     {
         return is_file($this->getFilepath($entryIdentifier)) || parent::has($entryIdentifier);
     }
@@ -145,7 +145,7 @@ public function has($entryIdentifier)
      *
      * @return bool TRUE if (at least) an entry could be removed or FALSE if no entry was found
      */
-    public function remove($entryIdentifier)
+    public function remove(string $entryIdentifier): bool
     {
         if (!$this->has($entryIdentifier)) {
             return false;

Classes/Cache/UriFrontend.php

@@ -16,12 +16,8 @@ class UriFrontend extends VariableFrontend
 {
     /**
      * Check if the identifier is a valid URI incl. host and path.
-     *
-     * @param string $identifier
-     *
-     * @return bool
      */
-    public function isValidEntryIdentifier($identifier)
+    public function isValidEntryIdentifier(string $identifier): bool
     {
         try {
             $identifierBuilder = GeneralUtility::makeInstance(IdentifierBuilder::class);

phpstan.neon

@@ -4,3 +4,6 @@ includes:
 parameters:
 	level: 5
 	reportUnmatchedIgnoredErrors: false
+	paths:
+		- Classes
+		- Tests