Remove symbolic in task-spec

Author: lockshaw

lib/local-pcg-execution/src/local-pcg-execution/execute_tasks_for_parallel_layer.cc

@@ -4,7 +4,6 @@
 #include "local-pcg-execution/local_parallel_tensor_backing.h"
 #include "local-pcg-execution/task_group_execution_times.dtg.h"
 #include "task-spec/fwb_op_task_type.h"
-#include "task-spec/symbolic/training_symbolic_computation_graph.h"
 #include "utils/containers/flatmap.h"
 #include "utils/containers/lift_optional_through_map.h"
 #include "utils/containers/map_values.h"

lib/task-spec/include/task-spec/dynamic_graph/dynamic_open_dataflow_graph.h

@@ -8,6 +8,8 @@ namespace FlexFlow {
 
 DynamicOpenDataflowGraph make_empty_dynamic_open_dataflow_graph();
 
+nonnegative_int dynamic_graph_num_nodes(DynamicOpenDataflowGraph const &);
+
 bool full_dynamic_graph_satisfies(
   DynamicOpenDataflowGraph const &,
   std::function<bool(DynamicNodeAttrs const &)> const &,

lib/task-spec/include/task-spec/loss_functions.h

@@ -17,9 +17,6 @@
 #define _FLEXFLOW_LIB_TASK_SPEC_INCLUDE_TASK_SPEC_LOSS_FUNCTIONS_H
 
 #include "op-attrs/ops/loss_functions.h"
-#include "task-spec/symbolic/symbolic_forward_tensor_guid_t.dtg.h"
-#include "task-spec/symbolic/symbolic_gradient_tensor_guid_t.dtg.h"
-#include "task-spec/symbolic/symbolic_loss_tensor_guid_t.dtg.h"
 #include "task-spec/task_impl_function.dtg.h"
 
 namespace FlexFlow {

lib/task-spec/include/task-spec/lower_op_task_invocation_to_runtime_task_invocation.h

@@ -7,21 +7,16 @@
 #include "task-spec/ops/op_arg_ref_spec.h"
 #include "task-spec/runtime_task_invocation/runtime_arg_ref_spec.h"
 #include "task-spec/runtime_task_invocation/runtime_arg_config.dtg.h"
-#include "task-spec/symbolic/symbolic_layer_training_tensor_group_signature.dtg.h"
-#include "task-spec/symbolic/symbolic_layer_training_tensor_group_signature_with_shapes.dtg.h"
-#include "task-spec/symbolic/symbolic_training_tensor_guid_t.dtg.h"
-#include "task-spec/symbolic/symbolic_layer_training_tensor_group_signature_with_shapes.dtg.h"
-#include "task-spec/symbolic/symbolic_layer_tensor_shape_signature.dtg.h"
 
 namespace FlexFlow {
 
-// TODO(@lockshaw)(#pr): this really shouldn't be here
-ConcreteArgSpec
-  lower_runtime_arg_ref_spec_to_concrete_arg_spec(
-    RuntimeArgRefSpec const &,
-    RuntimeArgConfig const &r,
-    DeviceSpecific<device_handle_t> const &,
-    std::function<std::optional<DeviceSpecificPerDeviceOpState>(symbolic_layer_guid_t)> const &);
+// TODO(@lockshaw)(#pr): 
+// ConcreteArgSpec
+//   lower_runtime_arg_ref_spec_to_concrete_arg_spec(
+//     RuntimeArgRefSpec const &,
+//     RuntimeArgConfig const &r,
+//     DeviceSpecific<device_handle_t> const &,
+//     std::function<std::optional<DeviceSpecificPerDeviceOpState>(symbolic_layer_guid_t)> const &);
 
 ConcreteArgSpec lower_argumentless_arg_ref_to_concrete_arg_spec(
     ArgumentlessRuntimeArgRefType,

lib/task-spec/include/task-spec/runtime_task_invocation/per_device_op_state_runtime_arg_ref_type.dtg.toml

@@ -9,9 +9,9 @@ features = [
 ]
 
 includes = [
-  "task-spec/symbolic/symbolic_layer_guid_t.dtg.h",
+  "pcg/parallel_computation_graph/parallel_layer_guid_t.dtg.h",
 ]
 
 [[fields]]
 name = "layer"
-type = "::FlexFlow::symbolic_layer_guid_t"
+type = "::FlexFlow::parallel_layer_guid_t"

lib/task-spec/include/task-spec/runtime_task_invocation/runtime_arg_ref.h

@@ -20,7 +20,7 @@ RuntimeArgRef<ProfilingSettings> profiling_settings();
 RuntimeArgRef<DeviceSpecific<device_handle_t>> ff_handle();
 RuntimeArgRef<FFIterationConfig> iteration_config();
 RuntimeArgRef<DeviceType> kernel_device_type();
-RuntimeArgRef<PerDeviceOpState> per_device_op_state_for_layer(symbolic_layer_guid_t);
+RuntimeArgRef<PerDeviceOpState> per_device_op_state_for_layer(parallel_layer_guid_t);
 
 } // namespace FlexFlow
 

lib/task-spec/include/task-spec/runtime_task_invocation/runtime_arg_spec.h

@@ -3,21 +3,21 @@
 
 #include "task-spec/ops/op_arg_spec.dtg.h"
 #include "task-spec/runtime_task_invocation/runtime_arg_spec.dtg.h"
-#include "task-spec/symbolic/symbolic_layer_tensor_shape_signature.dtg.h"
 
 namespace FlexFlow {
 
 std::type_index get_type_index(RuntimeArgSpec const &);
 
-RuntimeArgSpec lower_op_arg_spec_to_runtime_arg_spec(
-    OpArgSpec const &op_arg_spec,
-    symbolic_layer_guid_t symbolic_layer_guid,
-    SymbolicLayerTensorShapeSignature const &op_shape_signature);
-
-RuntimeArgSpec lower_op_arg_ref_spec_to_runtime_arg_spec(
-    OpArgRefSpec const &,
-    symbolic_layer_guid_t symbolic_layer_guid,
-    SymbolicLayerTensorShapeSignature const &);
+// TODO(@lockshaw)(#pr): 
+// RuntimeArgSpec lower_op_arg_spec_to_runtime_arg_spec(
+//     OpArgSpec const &op_arg_spec,
+//     symbolic_layer_guid_t symbolic_layer_guid,
+//     SymbolicLayerTensorShapeSignature const &op_shape_signature);
+//
+// RuntimeArgSpec lower_op_arg_ref_spec_to_runtime_arg_spec(
+//     OpArgRefSpec const &,
+//     symbolic_layer_guid_t symbolic_layer_guid,
+//     SymbolicLayerTensorShapeSignature const &);
 
 }