Fix roslint issues

Author: efernandez

fuse_models/test/test_imu_2d.cpp

@@ -45,11 +45,13 @@
 
 #include <gtest/gtest.h>
 
+#include <algorithm>
 #include <chrono>
 #include <mutex>
 #include <string>
 #include <thread>
 #include <utility>
+#include <vector>
 
 /**
  * @brief Imu2D test fixture
@@ -131,7 +133,7 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
 
   setCmdVel(twist);
 
-  using namespace std::chrono_literals;
+  using namespace std::chrono_literals;  // NOLINT(build/namespaces)
   std::this_thread::sleep_for(3s);
 
   // Confirm the last transaction has the expect number of variables and constraints generated by the imu sensor model
@@ -175,9 +177,10 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
   const auto& w = last_odom.twist.twist.angular.z;
 
   // That is, ensure there is one fuse_variables::VelocityAngular2DStamped variable
-  EXPECT_EQ(1, std::count_if(added_variables.begin(), added_variables.end(), [](const auto& variable) -> bool {
-              return dynamic_cast<const fuse_variables::VelocityAngular2DStamped*>(&variable);
-            }));
+  EXPECT_EQ(1, std::count_if(added_variables.begin(), added_variables.end(),
+                             [](const auto& variable) -> bool {  // NOLINT(whitespace/braces)
+                               return dynamic_cast<const fuse_variables::VelocityAngular2DStamped*>(&variable);
+                             }));  // NOLINT(whitespace/braces)
 
   // And iterate over all added variables to process it
   for (const auto& variable : added_variables)
@@ -197,9 +200,11 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
   // wheel odometry twist angular velocity along the z axis
 
   // That is, ensure there is one fuse_constraints::AbsoluteVelocityAngular2DStampedConstraint constraint
-  EXPECT_EQ(1, std::count_if(added_constraints.begin(), added_constraints.end(), [](const auto& constraint) -> bool {
-              return dynamic_cast<const fuse_constraints::AbsoluteVelocityAngular2DStampedConstraint*>(&constraint);
-            }));
+  EXPECT_EQ(1, std::count_if(added_constraints.begin(), added_constraints.end(),
+                             [](const auto& constraint) -> bool {  // NOLINT(whitespace/braces)
+                               return dynamic_cast<const fuse_constraints::AbsoluteVelocityAngular2DStampedConstraint*>(
+                                   &constraint);
+                             }));  // NOLINT(whitespace/braces)
 
   // And iterate over all added constraints to process it
   for (const auto& constraint : added_constraints)
@@ -223,9 +228,10 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
   // axis
 
   // That is, ensure there are two fuse_variables::Orientation2DStamped variables
-  EXPECT_EQ(2, std::count_if(added_variables.begin(), added_variables.end(), [](const auto& variable) -> bool {
-              return dynamic_cast<const fuse_variables::Orientation2DStamped*>(&variable);
-            }));
+  EXPECT_EQ(2, std::count_if(added_variables.begin(), added_variables.end(),
+                             [](const auto& variable) -> bool {  // NOLINT(whitespace/braces)
+                               return dynamic_cast<const fuse_variables::Orientation2DStamped*>(&variable);
+                             }));  // NOLINT(whitespace/braces)
 
   // Iterate over all added variables to process retrieve the fuse_variables::Orientation2DStamped variables
   std::vector<const fuse_variables::Orientation2DStamped*> orientations;
@@ -243,7 +249,7 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
 
   // Sort them by stamp
   std::sort(orientations.begin(), orientations.end(),
-            [](const auto& lhs, const auto& rhs) { return lhs->stamp() < rhs->stamp(); });
+            [](const auto& lhs, const auto& rhs) { return lhs->stamp() < rhs->stamp(); });  // NOLINT(whitespace/braces)
 
   // And check the angular velocity is the same as the wheel odometry one
   //
@@ -259,9 +265,11 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
   // odometry twist angular velocity along the z axis
 
   // That is, ensure there is one fuse_constraints::RelativePose2DStampedConstraint constraint
-  EXPECT_EQ(1, std::count_if(added_constraints.begin(), added_constraints.end(), [](const auto& constraint) -> bool {
-              return dynamic_cast<const fuse_constraints::RelativePose2DStampedConstraint*>(&constraint);
-            }));
+  EXPECT_EQ(1,
+            std::count_if(added_constraints.begin(), added_constraints.end(),
+                          [](const auto& constraint) -> bool {  // NOLINT(whitespace/braces)
+                            return dynamic_cast<const fuse_constraints::RelativePose2DStampedConstraint*>(&constraint);
+                          }));  // NOLINT(whitespace/braces)
 
   // And iterate over all added constraints to process it
   for (const auto& constraint : added_constraints)
@@ -284,17 +292,19 @@ TEST_F(Imu2DTestFixture, BaseFrameYawAngularVelocity)
     const auto& position1_uuid = variables[0];
     const auto& position2_uuid = variables[2];
 
-    const auto position1_iter =
-        std::find_if(added_variables.begin(), added_variables.end(),
-                     [&position1_uuid](const auto& variable) { return variable.uuid() == position1_uuid; });
+    const auto position1_iter = std::find_if(added_variables.begin(), added_variables.end(),
+                                             [&position1_uuid](const auto& variable) {  // NOLINT(whitespace/braces)
+                                               return variable.uuid() == position1_uuid;
+                                             });  // NOLINT(whitespace/braces)
     ASSERT_NE(added_variables.end(), position1_iter);
 
     const auto position1 = dynamic_cast<const fuse_variables::Position2DStamped*>(&*position1_iter);
     ASSERT_TRUE(position1);
 
-    const auto position2_iter =
-        std::find_if(added_variables.begin(), added_variables.end(),
-                     [&position2_uuid](const auto& variable) { return variable.uuid() == position2_uuid; });
+    const auto position2_iter = std::find_if(added_variables.begin(), added_variables.end(),
+                                             [&position2_uuid](const auto& variable) {  // NOLINT(whitespace/braces)
+                                               return variable.uuid() == position2_uuid;
+                                             });  // NOLINT(whitespace/braces)
     ASSERT_NE(added_variables.end(), position2_iter);
 
     const auto position2 = dynamic_cast<const fuse_variables::Position2DStamped*>(&*position2_iter);