reduce gc pressure

fix

Author: lofcz

src/Infidex.Tests/MovieSearchParityTests.cs

@@ -329,14 +329,13 @@ public void Search_Star_VerifyGrouping()
         var stargirl = records.FirstOrDefault(r => movies[(int)r.DocumentId].Title == "Stargirl");
         var stardust = records.FirstOrDefault(r => movies[(int)r.DocumentId].Title == "Stardust");
 
-        if (starKid == default(ScoreEntry)) Console.WriteLine("MISSING: Star Kid");
-        if (stardom == default(ScoreEntry)) Console.WriteLine("MISSING: Stardom");
+        if (starKid.DocumentId == 0 && starKid.Score == 0 && movies[0].Title != "Star Kid") Console.WriteLine("MISSING: Star Kid");
+        if (stardom.DocumentId == 0 && stardom.Score == 0 && movies[0].Title != "Stardom") Console.WriteLine("MISSING: Stardom");
 
         // Verify we found the key documents
-        // Note: ScoreEntry is a struct, so default is mostly zeros. We check DocumentId is not 0 (assuming 0 is not Star Kid/Stardom, which is safe given 40k movies)
-        // Or safer: check if we found them by checking ID against list if we had map, but here we rely on FirstOrDefault logic
-        // Better check:
-        bool foundStarKid = starKid.Score > 0 || (starKid.DocumentId == 0 && movies[0].Title == "Star Kid");
+        // Since ScoreEntry is a struct, default value has DocumentId=0 and Score=0.
+        // We check if Score > 0 to confirm it was found (assuming no valid result has score 0).
+        bool foundStarKid = starKid.Score > 0 || (starKid.DocumentId == 0 && movies[0].Title == "Star Kid" && starKid.Score > 0);
         bool foundStardom = stardom.Score > 0;
 
         Assert.IsTrue(foundStarKid, "Should find 'Star Kid'");

src/Infidex.Tests/ReferenceMatchingTests.cs

@@ -69,7 +69,7 @@ public void Search_Battamam_ReturnsCorrectDocuments()
         Console.WriteLine($"battamam returned {result.Records.Length} results:");
         foreach (var r in result.Records)
         {
-            Console.WriteLine($"  [{r.Score:D3}] Doc {r.DocumentId}");
+            Console.WriteLine($"  [{r.Score:F3}] Doc {r.DocumentId}");
         }
 
         // Expected: 1 result, Doc 6 at position 0

src/Infidex.Tests/SchoolSearchParityTests.cs

@@ -124,7 +124,7 @@ public void MaterskaSkolaWithBelohrad_PrefersBelohradskaSkola_AllPermutations()
             }
 
             int targetIndex = -1;
-            int targetScore = -1;
+            float targetScore = -1;
 
             for (int i = 0; i < records.Length; i++)
             {
@@ -217,8 +217,8 @@ public void Sciozli_ZlinScoresHigherThanKolin()
             $"First result should be ScioŠkola Zlín, but was: {firstDoc.IndexedText}");
 
         // Find scores for both schools
-        int zlinScore = -1;
-        int kolinScore = -1;
+        float zlinScore = -1;
+        float kolinScore = -1;
 
         foreach (var record in records)
         {
@@ -299,8 +299,8 @@ public void Sciozlinskaskola_ZlinRanksFirst()
             $"First result should be ScioŠkola Zlín (query contains 'zlín'), but was: {firstDoc.IndexedText}");
 
         // Find scores for both schools
-        int zlinScore = -1;
-        int kolinScore = -1;
+        float zlinScore = -1;
+        float kolinScore = -1;
 
         foreach (var record in records)
         {
@@ -352,8 +352,8 @@ public void Sciozlin_Query_ReturnsSchool()
             $"First result should be ScioŠkola Zlín for 'sciozlín', but was: {topDoc.IndexedText}");
 
         // If Kolín appears, it must have a lower score
-        int zlinScore = records[0].Score;
-        int kolinScore = -1;
+        float zlinScore = records[0].Score;
+        float kolinScore = -1;
 
         foreach (var record in records)
         {
@@ -402,7 +402,7 @@ public void ScioskolaCityAbbreviation_RanksCorrectCityFirst(string query, string
             $"First result should contain '{expectedSchoolSubstring}', but was: {firstDoc.IndexedText}");
 
         // Requirement 2: The correct ScioŠkola must have a strictly higher score than others
-        int targetScore = records[0].Score;
+        float targetScore = records[0].Score;
         for (int i = 1; i < records.Length; i++)
         {
             var doc = engine.GetDocument(records[i].DocumentId);
@@ -471,7 +471,7 @@ public void TyrsovkaCeskaLipa_PrefersCeskaLipaSchool()
         const string targetName = "Základní škola Dr. Miroslava Tyrše, Česká Lípa, Mánesova 1526, příspěvková organizace";
 
         int targetIndex = -1;
-        int targetScore = -1;
+        float targetScore = -1;
 
         for (int i = 0; i < records.Length; i++)
         {

src/Infidex.Tests/ScoreArrayTests.cs

@@ -26,7 +26,7 @@ public class Result
     /// <summary>
     /// Score of the last record in the result set (for pagination)
     /// </summary>
-    public ushort TruncationScore { get; set; }
+    public float TruncationScore { get; set; }
 
     /// <summary>
     /// Indicates if the query execution timed out
@@ -59,7 +59,7 @@ public class Result
     /// Creates a result with full metadata
     /// </summary>
     public Result(ScoreEntry[] records, Dictionary<string, KeyValuePair<string, int>[]>? facets, 
-                  int truncationIndex, ushort truncationScore, bool didTimeOut)
+                  int truncationIndex, float truncationScore, bool didTimeOut)
     {
         Records = records;
         Facets = facets;
@@ -80,16 +80,14 @@ public Result(ScoreEntry[] records, int totalCandidates)
         ExecutionTimeMs = 0;
         DidTimeOut = false;
         TruncationIndex = records.Length > 0 ? records.Length - 1 : 0;
-        TruncationScore = records.Length > 0 ? records[^1].Score : (byte)0;
+        TruncationScore = records.Length > 0 ? records[^1].Score : 0f;
     }
 
     /// <summary>
     /// Creates an empty result
     /// </summary>
     public static Result MakeEmptyResult(bool timedOut = false)
     {
-        return new Result([], null, 0, 0, timedOut);
+        return new Result([], null, 0, 0f, timedOut);
     }
 }
-
-

src/Infidex/Api/Result.cs

@@ -367,7 +367,7 @@ public void Compact()
             _documents.AddRange(compacted);
 
             _keyToIds.Clear();
-            foreach (var kvp in newKeyToIds)
+            foreach (KeyValuePair<long, List<int>> kvp in newKeyToIds)
                 _keyToIds[kvp.Key] = kvp.Value;
         }
         finally