Better resize event propagation. Should there be code to catch loops?

Author: loftafi

build.zig.zon

@@ -1,6 +1,6 @@
 .{
     .name = .engine,
-    .version = "0.12.1",
+    .version = "0.12.2",
     .fingerprint = 0xe8a81a8d0aa558d5,
     .minimum_zig_version = "0.15.2",
     .dependencies = .{

src/engine.zig

@@ -673,13 +673,20 @@ pub fn Display(comptime T: type) type {
         pub fn relayout(display: *Self) void {
             if (display.need_relayout == false) return;
 
+            trace("relayout", .{});
+
             display.need_relayout = false;
 
             const resized = display.root.type.panel.layout(display, &display.root);
             if (resized) {
                 if (display.on_resized.call(display, &display.root)) {
                     _ = display.root.type.panel.layout(display, &display.root);
                 }
+                const child_resized = display.propagate_resize_event(&display.root);
+                if (child_resized) {
+                    display.need_relayout = true;
+                    display.relayout();
+                }
             }
         }
 
@@ -1538,14 +1545,16 @@ pub fn Display(comptime T: type) type {
         }
 
         /// Trigger `on_resized` events on each node in the tree.
-        fn propagate_resize_event(self: *Self, parent: *Entity(T)) bool {
+        fn propagate_resize_event(self: *Self, entity: *Entity(T)) bool {
             var updated = false;
-            if (parent.visible == .visible)
-                updated = parent.on_resized.call(self, parent);
+            if (entity.visible == .visible)
+                updated = entity.on_resized.call(self, entity);
 
-            if (parent.type == .panel) {
-                for (parent.type.panel.children.items) |entity| {
-                    updated = self.propagate_resize_event(entity) or updated;
+            if (entity.type == .panel) {
+                for (entity.type.panel.children.items) |child| {
+                    if (child.visible == .visible) {
+                        updated = self.propagate_resize_event(child) or updated;
+                    }
                 }
             }
 

src/panel.zig

@@ -262,26 +262,10 @@ pub fn Panel(comptime T: type) type {
                         if (entity.maximum.width > 0 and new_width > entity.maximum.width) {
                             new_width = entity.maximum.width;
                         }
-                        if (entity.type == .label) {
-                            debug("dolayout label {s} width={d} new_width={d} inner_width={d}", .{
-                                entity.type.label.translated,
-                                entity.rect.width,
-                                new_width,
-                                entity.inner_width(),
-                            });
-                        }
                         if (entity.rect.width != new_width) {
                             entity.rect.width = new_width;
                             child_resized = true;
                         }
-                        if (entity.type == .label) {
-                            debug("`-layout label {s} width={d} new_width={d} inner_width={d}", .{
-                                entity.type.label.translated,
-                                entity.rect.width,
-                                new_width,
-                                entity.inner_width(),
-                            });
-                        }
                     },
                     .shrinks => {
                         // Shrink to the smallest the children will allow.
@@ -337,13 +321,6 @@ pub fn Panel(comptime T: type) type {
             for (self.children.items) |entity| {
                 if (entity.visible == .hidden) continue;
                 if (entity.type == .label) {
-                    debug("relayout label {s} width={d} inner_width={d} align={t} grows={t}", .{
-                        entity.type.label.translated,
-                        entity.rect.width,
-                        entity.inner_width(),
-                        entity.child_align.x,
-                        entity.layout.x,
-                    });
                     const content_size = entity.layout_label(display.scale, available_width);
                     entity.rect.width = switch (entity.layout.x) {
                         .grows => available_width + entity.pad.left + entity.pad.right,