feat: Add comprehensive system prompt management system. (#1969)

* feat: Add comprehensive system prompt management system.

* fix：fixed some bugs

* fix: prevent false negatives in migration content verification

Strip leading newlines before comparing saved vs original content.
Obsidian may insert extra blank line after frontmatter block,
causing stripFrontmatter to leave a leading newline and fail verification.

Author: Emt-lin

package-lock.json

@@ -102,19 +102,19 @@
     "@orama/orama": "^3.0.0-rc-2",
     "@radix-ui/react-checkbox": "^1.1.3",
     "@radix-ui/react-collapsible": "^1.1.2",
-    "@radix-ui/react-dialog": "^1.1.3",
+    "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.4",
-    "@radix-ui/react-label": "^2.1.0",
+    "@radix-ui/react-label": "^2.1.7",
     "@radix-ui/react-popover": "^1.1.15",
     "@radix-ui/react-progress": "^1.1.7",
     "@radix-ui/react-scroll-area": "^1.2.10",
-    "@radix-ui/react-select": "^2.1.2",
+    "@radix-ui/react-select": "^2.2.6",
     "@radix-ui/react-separator": "^1.1.7",
     "@radix-ui/react-slider": "^1.3.5",
     "@radix-ui/react-slot": "^1.2.3",
     "@radix-ui/react-switch": "^1.1.1",
     "@radix-ui/react-tabs": "^1.1.3",
-    "@radix-ui/react-tooltip": "^1.2.7",
+    "@radix-ui/react-tooltip": "^1.2.8",
     "@tabler/icons-react": "^2.14.0",
     "async-mutex": "^0.5.0",
     "axios": "^1.3.4",

package.json

@@ -16,7 +16,8 @@ import {
   VaultQAChainRunner,
 } from "@/LLMProviders/chainRunner/index";
 import { logError, logInfo } from "@/logger";
-import { getSettings, getSystemPrompt, subscribeToSettingsChange } from "@/settings/model";
+import { getSettings, subscribeToSettingsChange } from "@/settings/model";
+import { getSystemPrompt } from "@/system-prompts/systemPromptBuilder";
 import { ChatMessage } from "@/types/message";
 import { findCustomModel, isOSeriesModel, isSupportedChain } from "@/utils";
 import { MissingModelKeyError } from "@/error";

src/LLMProviders/chainManager.ts

@@ -3,7 +3,8 @@ import { MessageContent } from "@/imageProcessing/imageProcessor";
 import { logError, logInfo, logWarn } from "@/logger";
 import { UserMemoryManager } from "@/memory/UserMemoryManager";
 import { checkIsPlusUser } from "@/plusUtils";
-import { getSettings, getSystemPromptWithMemory } from "@/settings/model";
+import { getSettings } from "@/settings/model";
+import { getSystemPromptWithMemory } from "@/system-prompts/systemPromptBuilder";
 import { initializeBuiltinTools } from "@/tools/builtinTools";
 import { extractParametersFromZod, SimpleTool } from "@/tools/SimpleTool";
 import { ToolRegistry } from "@/tools/ToolRegistry";

src/LLMProviders/chainRunner/AutonomousAgentChainRunner.ts

@@ -15,7 +15,8 @@ import {
 } from "@/imageProcessing/imageProcessor";
 import { logInfo, logWarn } from "@/logger";
 import { checkIsPlusUser } from "@/plusUtils";
-import { getSettings, getSystemPromptWithMemory } from "@/settings/model";
+import { getSettings } from "@/settings/model";
+import { getSystemPromptWithMemory } from "@/system-prompts/systemPromptBuilder";
 import { writeToFileTool } from "@/tools/ComposerTools";
 import { ToolManager } from "@/tools/toolManager";
 import { ToolResultFormatter } from "@/tools/ToolResultFormatter";

src/LLMProviders/chainRunner/CopilotPlusChainRunner.ts

@@ -194,7 +194,7 @@ class BaseModelAdapter implements ModelAdapter {
       {
         id: "base-system-prompt",
         label: "System prompt with memory",
-        source: "src/settings/model.ts#getSystemPromptWithMemory",
+        source: "src/system-prompts/systemPromptBuilder.ts#getSystemPromptWithMemory",
         content: normalizedBasePrompt,
       },
       {

src/LLMProviders/chainRunner/utils/modelAdapter.ts

@@ -1,5 +1,5 @@
 import ChainManager from "@/LLMProviders/chainManager";
-import { getSystemPromptWithMemory } from "@/settings/model";
+import { getSystemPromptWithMemory } from "@/system-prompts/systemPromptBuilder";
 import { ToolMetadata, ToolRegistry } from "@/tools/ToolRegistry";
 import { ChatMessage } from "@/types/message";
 import { messageRequiresTools, ModelAdapter } from "./modelAdapter";

src/LLMProviders/chainRunner/utils/promptDebugService.ts

@@ -1,4 +1,5 @@
-import { getSystemPrompt, subscribeToSettingsChange } from "@/settings/model";
+import { subscribeToSettingsChange } from "@/settings/model";
+import { getSystemPrompt } from "@/system-prompts/systemPromptBuilder";
 import {
   ChatPromptTemplate,
   HumanMessagePromptTemplate,

src/LLMProviders/promptManager.ts

@@ -2,7 +2,7 @@ import { ChainType } from "@/chainFactory";
 import { BaseChatModel } from "@langchain/core/language_models/chat_models";
 import { ChatPromptTemplate } from "@langchain/core/prompts";
 
-import { ModelCapability } from "@/constants";
+import { ModelCapability, ReasoningEffort, Verbosity } from "@/constants";
 import { settingsAtom, settingsStore } from "@/settings/model";
 import { SelectedTextContext } from "@/types/message";
 import { atom, useAtom } from "jotai";
@@ -150,8 +150,8 @@ export interface CustomModel {
   bedrockRegion?: string;
 
   // OpenAI GPT-5 and O-series specific fields
-  reasoningEffort?: "minimal" | "low" | "medium" | "high";
-  verbosity?: "low" | "medium" | "high";
+  reasoningEffort?: ReasoningEffort;
+  verbosity?: Verbosity;
 }
 
 export function setModelKey(modelKey: string) {

src/aiParams.ts

@@ -30,14 +30,18 @@ jest.mock("@/logger", () => ({
 }));
 
 // Mock the utility functions
-jest.mock("@/utils", () => ({
-  extractTemplateNoteFiles: jest.fn().mockReturnValue([]),
-  getFileContent: jest.fn(),
-  getFileName: jest.fn(),
-  getNotesFromPath: jest.fn(),
-  getNotesFromTags: jest.fn(),
-  processVariableNameForNotePath: jest.fn(),
-}));
+jest.mock("@/utils", () => {
+  const actual = jest.requireActual("@/utils");
+  return {
+    extractTemplateNoteFiles: jest.fn().mockReturnValue([]),
+    getFileContent: jest.fn(),
+    getFileName: jest.fn(),
+    getNotesFromPath: jest.fn(),
+    getNotesFromTags: jest.fn(),
+    processVariableNameForNotePath: jest.fn(),
+    stripFrontmatter: actual.stripFrontmatter,
+  };
+});
 
 describe("processedPrompt()", () => {
   let mockVault: Vault;
@@ -144,6 +148,19 @@ describe("processedPrompt()", () => {
     expect(result.includedFiles).toEqual([]);
   });
 
+  it("should treat {} as literal when skipEmptyBraces is true", async () => {
+    const customPrompt = "Rewrite the following text {}";
+    const selectedText = "here is some selected text 12345";
+
+    const result = await processPrompt(customPrompt, selectedText, mockVault, mockActiveNote, true);
+
+    // {} should be preserved as literal, not replaced
+    expect(result.processedPrompt).toBe("Rewrite the following text {}\n\n");
+    expect(result.includedFiles).toEqual([]);
+    expect(result.processedPrompt).not.toContain("<selected_text>");
+    expect(result.processedPrompt).not.toContain("{selected_text}");
+  });
+
   it("should process {activeNote} correctly", async () => {
     const doc: CustomCommand = {
       title: "test-prompt",
@@ -785,6 +802,17 @@ describe("validateCommandName", () => {
 
   it("returns null if unchanged currentCommandName", () => {
     expect(validateCommandName("Command One", baseCommands, "Command One")).toBeNull();
-    expect(validateCommandName("  Command One  ", baseCommands, "Command One")).toBeNull();
+  });
+
+  it("returns error for names with leading or trailing whitespace", () => {
+    expect(validateCommandName("  Command One  ", baseCommands)).toBe(
+      "Command name cannot have leading or trailing spaces"
+    );
+    expect(validateCommandName(" Leading", baseCommands)).toBe(
+      "Command name cannot have leading or trailing spaces"
+    );
+    expect(validateCommandName("Trailing ", baseCommands)).toBe(
+      "Command name cannot have leading or trailing spaces"
+    );
   });
 });