Skip to content

Commit 4c7a0fe

Browse files
authored
Fix flaky flushWithNullOutputStream test (#1101)
outputStreamDelegate appender will add an error since the outputStream is null
1 parent 5fc4dac commit 4c7a0fe

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/test/java/net/logstash/logback/appender/DelegatingAsyncDisruptorAppenderTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package net.logstash.logback.appender;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19+
import static org.awaitility.Awaitility.await;
1920
import static org.mockito.Mockito.doThrow;
2021
import static org.mockito.Mockito.inOrder;
2122
import static org.mockito.Mockito.mock;
@@ -29,6 +30,7 @@
2930
import java.io.Flushable;
3031
import java.io.IOException;
3132
import java.io.OutputStream;
33+
import java.time.Duration;
3234

3335
import net.logstash.logback.appender.listener.AppenderListener;
3436

@@ -215,7 +217,11 @@ public void flushWithNullOutputStream() {
215217
outputStreamDelegate.setOutputStream(null);
216218
appender.doAppend(event);
217219

218-
assertThat(appender.getStatusManager().getCount()).isZero();
220+
verify(outputStreamDelegate, timeout(VERIFICATION_TIMEOUT)).doAppend(event);
221+
222+
await()
223+
.timeout(Duration.ofMillis(VERIFICATION_TIMEOUT))
224+
.untilAsserted(() -> assertThat(appender.getStatusManager().getCount()).isEqualTo(1));
219225
}
220226

221227

0 commit comments

Comments
 (0)