Merge pull request #4 from anacarolinats/master

Added HTTPErrorException, fixed processor_code bug and improve readability

Author: tcana1

maxipago/exceptions.py

@@ -29,3 +29,8 @@ class CardException(MaxipagoException):
 
 class PaymentException(MaxipagoException):
     pass
+
+
+#http
+class HttpErrorException(MaxipagoException):
+    pass

maxipago/managers/base.py

@@ -1,5 +1,6 @@
 # coding: utf-8
 import requests
+from maxipago.exceptions import HttpErrorException
 from maxipago.utils import etree, create_element_recursively
 
 
@@ -24,6 +25,9 @@ def __init__(self, maxid, api_key, api_version, sandbox):
     def request(self, xml_data, api_type=None):
         uri = self.get_uri(api_type)
         response = requests.post(url=uri, data=xml_data, headers={'content-type': 'text/xml'})
+
+        if not str(response.status_code).startswith('2'):
+            raise HttpErrorException(u'Error %s: %s' % (response.status_code, response.reason))
         return response
 
     def get_uri(self, api_type=None):

maxipago/resources/base.py

@@ -7,9 +7,6 @@ def __init__(self, data, requester, manager):
         self.data = data
         self.requester = requester
         self.manager = manager
-
-        print self.data
-
         self.process()
 
     def process(self):

maxipago/resources/payment.py

@@ -13,9 +13,14 @@ def process(self):
         self.captured = False
 
         tree = etree.parse(StringIO(self.data))
+        error_code = tree.find('errorCode')
+        if error_code is not None and error_code.text != '0':
+            error_message = tree.find('errorMsg').text
+            raise PaymentException(message=error_message)
 
         processor_code = tree.find('processorCode')
-        if processor_code.text.lower() == 'a':
+
+        if processor_code.text is not None and processor_code.text.lower() == 'a':
             self.approved = True
 
         if self.approved:

maxipago/utils/__init__.py

@@ -0,0 +1 @@
+from xml import *

maxipago/utils/payment_processors.py

@@ -0,0 +1,10 @@
+TEST, REDECARD, AMEX, CIELO, TEF, CHASEPAYMENTECH = '1', '2', '3', '4', '5', '8'
+
+PROCESSORS_CHOICES = (
+    (TEST, 'Simulador de testes'),
+    (REDECARD, 'Redecard'),
+    (AMEX, 'Amex'),
+    (CIELO, 'Cielo'),
+    (TEF, 'TEF'),
+    (CHASEPAYMENTECH, 'ChasePaymentech'),
+)

maxipago/utils.py maxipago/utils/xml.pymaxipago/utils.py renamed to maxipago/utils/xml.py

@@ -3,6 +3,7 @@
 import unittest
 from datetime import date
 from maxipago import Maxipago, exceptions
+from maxipago.utils import payment_processors
 from random import randint
 
 
@@ -157,7 +158,7 @@ def test_payment_authorize(self):
         REFERENCE = randint(1, 100000)
 
         response = self.maxipago.payment.authorize(
-            processor_id=1,
+            processor_id=payment_processors.TEST,
             reference_num=REFERENCE,
 
             billing_name=u'Fulano de Tal',
@@ -184,7 +185,7 @@ def test_payment_direct(self):
         REFERENCE = randint(1, 100000)
 
         response = self.maxipago.payment.direct(
-            processor_id=1,
+            processor_id=payment_processors.TEST,
             reference_num=REFERENCE,
 
             billing_name=u'Fulano de Tal',
@@ -211,7 +212,7 @@ def test_payment_direct_declined(self):
         REFERENCE = randint(1, 100000)
 
         response = self.maxipago.payment.direct(
-            processor_id=1,
+            processor_id=payment_processors.TEST,
             reference_num=REFERENCE,
 
             billing_name=u'Fulano de Tal',
@@ -234,5 +235,105 @@ def test_payment_direct_declined(self):
         self.assertFalse(response.authorized)
         self.assertFalse(response.captured)
 
+    def test_payment_direct_with_token(self):
+        CUSTOMER_ID = randint(1, 100000)
+
+        response = self.maxipago.customer.add(
+            customer_id=CUSTOMER_ID,
+            first_name=u'Fulano',
+            last_name=u'de Tal',
+        )
+
+        self.assertTrue(hasattr(response, 'id'))
+
+        maxipago_customer_id = response.id
+
+        response = self.maxipago.card.add(
+            customer_id=maxipago_customer_id,
+            number=u'4111111111111111',
+            expiration_month=u'02',
+            expiration_year=date.today().year + 3,
+            billing_name=u'Fulano de Tal',
+            billing_address1=u'Rua das Alamedas, 123',
+            billing_city=u'Rio de Janeiro',
+            billing_state=u'RJ',
+            billing_zip=u'20123456',
+            billing_country=u'BR',
+            billing_phone=u'552140634666',
+            billing_email=u'[email protected]',
+        )
+
+        self.assertTrue(getattr(response, 'token', False))
+        REFERENCE = randint(1, 100000)
+
+        response = self.maxipago.payment.direct(
+            processor_id=payment_processors.TEST,
+            reference_num=REFERENCE,
+
+            customer_id=maxipago_customer_id,
+            token=response.token,
+
+            charge_total='100.00',
+        )
+
+        self.assertTrue(response.authorized)
+        self.assertTrue(response.captured)
+
+    def test_payment_direct_with_token_decline(self):
+        CUSTOMER_ID = randint(1, 100000)
+
+        response = self.maxipago.customer.add(
+            customer_id=CUSTOMER_ID,
+            first_name=u'Fulano',
+            last_name=u'de Tal',
+        )
+
+        self.assertTrue(hasattr(response, 'id'))
+
+        maxipago_customer_id = response.id
+
+        response = self.maxipago.card.add(
+            customer_id=maxipago_customer_id,
+            number=u'4111111111111111',
+            expiration_month=u'02',
+            expiration_year=date.today().year + 3,
+            billing_name=u'Fulano de Tal',
+            billing_address1=u'Rua das Alamedas, 123',
+            billing_city=u'Rio de Janeiro',
+            billing_state=u'RJ',
+            billing_zip=u'20123456',
+            billing_country=u'BR',
+            billing_phone=u'552140634666',
+            billing_email=u'[email protected]',
+        )
+
+        self.assertTrue(getattr(response, 'token', False))
+        REFERENCE = randint(1, 100000)
+
+        response = self.maxipago.payment.direct(
+            processor_id=payment_processors.TEST,
+            reference_num=REFERENCE,
+
+            customer_id=maxipago_customer_id,
+            token=response.token,
+
+            charge_total='100.01',
+        )
+
+        self.assertFalse(response.authorized)
+        self.assertFalse(response.captured)
+
+    def test_http_exception(self):
+        CUSTOMER_ID = randint(1, 100000)
+        customer_manager = self.maxipago.customer
+        customer_manager.uri_api = 'https://testapi.maxipago.net/UniversalAPI/WrongUri'
+        with self.assertRaises(exceptions.HttpErrorException):
+            customer_manager.add(
+                customer_id=CUSTOMER_ID,
+                first_name='Fulano',
+                last_name='de Tal',
+            )
+
+
 if __name__ == '__main__':
     unittest.main()