new GWT 2.12.2 and SmartGWT 14.1p

car031 · car031 · commit 1c555707abab · 2025-04-09T11:31:30.000+02:00
diff --git a/logicaldoc-core/src/main/java/com/logicaldoc/core/RunLevel.java b/logicaldoc-core/src/main/java/com/logicaldoc/core/RunLevel.java
@@ -10,6 +10,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.logicaldoc.core.exception.AspectDisabledException;
 import com.logicaldoc.util.Context;
 import com.logicaldoc.util.config.ContextProperties;
 import com.logicaldoc.util.plugin.PluginRegistry;
@@ -61,6 +62,12 @@ public boolean aspectEnabled(String aspect) {
 		return config != null && config.getBoolean(getAspectProperty(aspect), false);
 	}
 
+	public void checkAspect(String aspect) throws AspectDisabledException {
+		if(!aspectEnabled(aspect))
+			throw new AspectDisabledException(aspect);
+	}
+
+	
 	public void setAspect(String aspect, boolean enabled) {
 		ContextProperties config = getConfig();
 		if (config != null)
diff --git a/logicaldoc-core/src/main/java/com/logicaldoc/core/exception/AspectDisabledException.java b/logicaldoc-core/src/main/java/com/logicaldoc/core/exception/AspectDisabledException.java
@@ -0,0 +1,20 @@
+package com.logicaldoc.core.exception;
+
+/**
+ * Raised when an aspect is disabled
+ * 
+ * @author Marco Meschieri - LogicalDOC
+ * @since 9.2
+ */
+public class AspectDisabledException extends FeatureDisabledException {
+
+	private static final long serialVersionUID = 1L;
+
+	public AspectDisabledException(String aspectId) {
+		super(aspectId, "Aspect ", "aspect.");
+	}
+
+	public AspectDisabledException(String aspectId, Throwable cause) {
+		super(aspectId, "Aspect ", "aspect.", cause);
+	}
+}
diff --git a/logicaldoc-core/src/main/java/com/logicaldoc/core/exception/FeatureDisabledException.java b/logicaldoc-core/src/main/java/com/logicaldoc/core/exception/FeatureDisabledException.java
@@ -12,11 +12,20 @@ public class FeatureDisabledException extends Exception {
 
 	private static final long serialVersionUID = 1L;
 
-	public FeatureDisabledException(int featureId) {
-		super("Feature " + I18N.message("feature.Feature_" + featureId));
+	protected FeatureDisabledException(String featureId, String messagePrefix, String featureKeyPrefix,
+			Throwable cause) {
+		super(messagePrefix + I18N.message(featureKeyPrefix + featureId), cause);
 	}
 
-	public FeatureDisabledException(int featureId, Throwable cause) {
-		super("Feature " + I18N.message("feature.Feature_" + featureId), cause);
+	protected FeatureDisabledException(String featureId, String messagePrefix, String featureKeyPrefix) {
+		super(messagePrefix + I18N.message(featureKeyPrefix + featureId));
+	}
+
+	public FeatureDisabledException(String featureId) {
+		this(featureId, "Feature ", "feature.Feature_");
+	}
+
+	public FeatureDisabledException(String featureId, Throwable cause) {
+		this(featureId, "Feature ", "feature.Feature_", cause);
 	}
 }
diff --git a/logicaldoc-core/src/main/java/com/logicaldoc/core/security/authentication/InvalidSessionException.java b/logicaldoc-core/src/main/java/com/logicaldoc/core/security/authentication/InvalidSessionException.java
@@ -13,7 +13,7 @@ public class InvalidSessionException extends AuthenticationException {
 	private final String sid;
 
 	public InvalidSessionException() {
-		sid = null;
+		sid = "";
 	}
 
 	public InvalidSessionException(String sid) {
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/Feature.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/Feature.java
@@ -225,7 +225,7 @@ public class Feature {
 
 	public static final int ONLYOFFICE = 107;
 
-	public static final int BOT = 108;
+	public static final int ROBOT = 108;
 	
 	private static Set<String> features = new HashSet<>();
 
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/Menu.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/Menu.java
@@ -223,7 +223,9 @@ public class Menu {
 	
 	public static final long AI_MODELS = 3001;
 	
-	public static final long ROBOTS = 3010;
+	public static final long ADMIN_ROBOTS = 3010;
+	
+	public static final long ROBOTS = 3020;
 
 	private static Set<Long> menus = new HashSet<>();
 
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/AIMenu.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/AIMenu.java
@@ -33,7 +33,7 @@ private void addModelsButton() {
 			addMember(models);
 		}
 
-		if (Menu.enabled(Menu.ROBOTS)) {
+		if (Menu.enabled(Menu.ADMIN_ROBOTS)) {
 			Button robots = new Button(I18N.message("robots"));
 			robots.setWidth100();
 			robots.setHeight(25);
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotSelector.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotSelector.java
@@ -0,0 +1,46 @@
+package com.logicaldoc.gui.frontend.client.ai.robot;
+
+import com.logicaldoc.gui.common.client.i18n.I18N;
+import com.smartgwt.client.widgets.form.fields.SelectItem;
+import com.smartgwt.client.widgets.grid.ListGridRecord;
+
+/**
+ * This widget allows for the selection of a robot
+ * 
+ * @author Marco Meschieri - LogicalDOC
+ * @since 9.2
+ */
+public class RobotSelector extends SelectItem {
+
+	private static final String LABEL = "label";
+
+	public RobotSelector() {
+		setName("robot");
+		setTitle(I18N.message("robot"));
+		setWrapTitle(false);
+
+		RobotListGridField label = new RobotListGridField(LABEL);
+
+		setValueField("id");
+		setDisplayField(LABEL);
+		setSortField(LABEL);
+		setPickListWidth(150);
+		setPickListFields(label);
+
+		setOptionDataSource(new RobotsDS());
+		setHintStyle("hint");
+	}
+
+	public GUIRobot getRobot() {
+		GUIRobot robot = null;
+		ListGridRecord selection = getSelectedRecord();
+		if (selection != null) {
+			robot = new GUIRobot();
+			robot.setId(selection.getAttributeAsLong("id"));
+			robot.setName(selection.getAttributeAsString("name"));
+			robot.setLabel(selection.getAttributeAsString(LABEL));
+			robot.setAvatar(selection.getAttributeAsString("avatar"));
+		}
+		return robot;
+	}
+}
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotThread.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotThread.java
@@ -8,7 +8,7 @@
 import com.logicaldoc.gui.common.client.util.AwesomeFactory;
 import com.logicaldoc.gui.common.client.util.ItemFactory;
 import com.logicaldoc.gui.common.client.util.WindowUtils;
-import com.logicaldoc.gui.frontend.client.chatgpt.ThreadWindow;
+import com.logicaldoc.gui.frontend.client.chatgpt.ChatGPTThread;
 import com.logicaldoc.gui.frontend.client.menu.MainMenu;
 import com.smartgwt.client.types.Alignment;
 import com.smartgwt.client.types.HeaderControls;
@@ -158,7 +158,7 @@ public void run() {
 	}
 
 	private String robotName() {
-		if (robot.getLabel() == null || robot.getLabel().isBlank())
+		if (robot.getLabel() == null || robot.getLabel().trim().isEmpty())
 			return robot.getName();
 		else
 			return robot.getLabel();
@@ -179,7 +179,7 @@ public void onSuccess(String answer) {
 
 	@Override
 	public boolean equals(Object obj) {
-		if (obj instanceof ThreadWindow)
+		if (obj instanceof ChatGPTThread)
 			return super.equals(obj);
 		else
 			return false;
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotTray.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/ai/robot/RobotTray.java
@@ -0,0 +1,55 @@
+package com.logicaldoc.gui.frontend.client.ai.robot;
+
+import com.logicaldoc.gui.common.client.DefaultAsyncCallback;
+import com.logicaldoc.gui.common.client.util.AwesomeFactory;
+import com.logicaldoc.gui.common.client.util.ItemFactory;
+import com.logicaldoc.gui.frontend.client.menu.MenuTray;
+import com.smartgwt.client.types.Alignment;
+import com.smartgwt.client.widgets.form.fields.FormItemIcon;
+import com.smartgwt.client.widgets.form.fields.TextItem;
+
+/**
+ * A tray to interact with the Robots
+ * 
+ * @author Marco Meschieri - LogicalDOC
+ * @since 9.2
+ */
+public class RobotTray extends MenuTray {
+
+	public RobotTray() {
+		TextItem question = ItemFactory.newTextItem("question", "");
+		question.setShowTitle(false);
+		question.setWidth(200);
+		question.addKeyPressHandler(event -> {
+			if (event.getKeyName() != null && "enter".equalsIgnoreCase(event.getKeyName()))
+				onAsk(question.getValueAsString());
+		});
+
+		FormItemIcon ask = new FormItemIcon();
+		ask.setInline(true);
+		ask.setInlineIconAlign(Alignment.RIGHT);
+		ask.setText(AwesomeFactory.getIconHtml("paper-plane"));
+		question.setIcons(ask);
+		ask.addFormItemClickHandler(click -> onAsk(question.getValueAsString()));
+
+		RobotSelector robot = new RobotSelector();
+		robot.setDefaultToFirstOption(true);
+		robot.setWidth(100);
+		
+		setNumCols(3);
+		
+		setItems(robot, question);
+	}
+
+	private void onAsk(String question) {
+		if (validate()) {
+			RobotService.Instance.get().get(Long.parseLong(getValueAsString("robot")), new DefaultAsyncCallback<>() {
+
+				@Override
+				public void onSuccess(GUIRobot rbt) {
+					RobotThread.get(rbt).open(getValueAsString("question"));
+				}
+			});
+		}
+	}
+}
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/chatgpt/ChatGPTThread.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/chatgpt/ChatGPTThread.java
@@ -27,7 +27,7 @@
  * @author Marco Meschieri - LogicalDOC
  * @since 8.9.4
  */
-public class ThreadWindow extends Window {
+public class ChatGPTThread extends Window {
 
 	private static final String CHATGPT = "chatgpt";
 
@@ -37,15 +37,15 @@ public class ThreadWindow extends Window {
 
 	private MessageBox lastMessage;
 
-	private static ThreadWindow instance = new ThreadWindow();
+	private static ChatGPTThread instance = new ChatGPTThread();
 
 	private Timer answerPolling;
 
-	public static ThreadWindow get() {
+	public static ChatGPTThread get() {
 		return instance;
 	}
 
-	private ThreadWindow() {
+	private ChatGPTThread() {
 		setHeaderControls(HeaderControls.HEADER_LABEL, HeaderControls.MINIMIZE_BUTTON, HeaderControls.CLOSE_BUTTON);
 		setTitle(I18N.message(CHATGPT));
 		setCanDragResize(true);
@@ -198,7 +198,7 @@ public void onSuccess(GUIValue answer) {
 
 	@Override
 	public boolean equals(Object obj) {
-		if (obj instanceof ThreadWindow)
+		if (obj instanceof ChatGPTThread)
 			return super.equals(obj);
 		else
 			return false;
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/chatgpt/ChatGPTTray.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/chatgpt/ChatGPTTray.java
@@ -40,6 +40,6 @@ private void onAsk(String question) {
 		if (DocumentController.get().getCurrentSelection().isEmpty())
 			SC.warn(I18N.message("nodocsselected"));
 		else
-			ThreadWindow.get().open(question);
+			ChatGPTThread.get().open(question);
 	}
 }
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/document/DocumentSecurityPanel.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/document/DocumentSecurityPanel.java
@@ -3,8 +3,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import com.logicaldoc.gui.common.client.Feature;
 import com.logicaldoc.gui.common.client.DefaultAsyncCallback;
+import com.logicaldoc.gui.common.client.Feature;
 import com.logicaldoc.gui.common.client.beans.GUIAccessControlEntry;
 import com.logicaldoc.gui.common.client.beans.GUIDocument;
 import com.logicaldoc.gui.common.client.beans.GUIFolder;
@@ -25,7 +25,6 @@
 import com.smartgwt.client.widgets.events.ClickEvent;
 import com.smartgwt.client.widgets.form.DynamicForm;
 import com.smartgwt.client.widgets.form.fields.SelectItem;
-import com.smartgwt.client.widgets.form.fields.events.ChangedEvent;
 import com.smartgwt.client.widgets.grid.ListGridField;
 import com.smartgwt.client.widgets.grid.ListGridRecord;
 import com.smartgwt.client.widgets.grid.events.CellContextClickEvent;
@@ -311,7 +310,7 @@ private void addUserSelector(HLayout buttons) {
 		final SelectItem user = ItemFactory.newUserSelector("user", "adduser", null, true, false);
 		userForm.setItems(user);
 
-		user.addChangedHandler(userChangedEvent -> {
+		user.addChangedHandler(changed -> {
 			ListGridRecord selectedRecord = user.getSelectedRecord();
 			if (selectedRecord == null)
 				return;
@@ -347,7 +346,7 @@ private void addGroupSelector(HLayout buttons) {
 		final DynamicForm groupForm = new DynamicForm();
 		final SelectItem group = ItemFactory.newGroupSelector("group", "addgroup");
 		groupForm.setItems(group);
-		group.addChangedHandler((ChangedEvent changedEvent) -> {
+		group.addChangedHandler(changed -> {
 			ListGridRecord selectedRecord = group.getSelectedRecord();
 			if (selectedRecord == null)
 				return;
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/menu/MainMenu.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/menu/MainMenu.java
@@ -11,8 +11,8 @@
 import com.google.gwt.user.client.Window;
 import com.logicaldoc.gui.common.client.Constants;
 import com.logicaldoc.gui.common.client.CookiesManager;
-import com.logicaldoc.gui.common.client.Feature;
 import com.logicaldoc.gui.common.client.DefaultAsyncCallback;
+import com.logicaldoc.gui.common.client.Feature;
 import com.logicaldoc.gui.common.client.Session;
 import com.logicaldoc.gui.common.client.beans.GUIAccessControlEntry;
 import com.logicaldoc.gui.common.client.beans.GUIDocument;
@@ -33,6 +33,7 @@
 import com.logicaldoc.gui.common.client.util.Util;
 import com.logicaldoc.gui.common.client.util.ValuesCallback;
 import com.logicaldoc.gui.common.client.util.WindowUtils;
+import com.logicaldoc.gui.frontend.client.ai.robot.RobotTray;
 import com.logicaldoc.gui.frontend.client.chatgpt.ChatGPTTray;
 import com.logicaldoc.gui.frontend.client.docusign.DocuSignSettings;
 import com.logicaldoc.gui.frontend.client.docusign.EnvelopeDetails;
@@ -115,6 +116,9 @@ private MainMenu() {
 		setWidth100();
 
 		trays.add(new QuickSearchTray());
+		if (Feature.enabled(Feature.ROBOT)
+				&& com.logicaldoc.gui.common.client.Menu.enabled(com.logicaldoc.gui.common.client.Menu.ROBOTS))
+			trays.add(new RobotTray());
 		if (Feature.enabled(Feature.CHATGPT)
 				&& com.logicaldoc.gui.common.client.Menu.enabled(com.logicaldoc.gui.common.client.Menu.CHATGPT))
 			trays.add(new ChatGPTTray());
@@ -305,15 +309,16 @@ public void onSuccess(Boolean connected) {
 		}));
 
 		final MenuItem importFrom = new MenuItem(I18N.message("importfromdropbox"));
-		importFrom.addClickHandler(event -> DropboxService.Instance.get().isConnected(new DefaultAsyncCallback<Boolean>() {
-			@Override
-			public void onSuccess(Boolean connected) {
-				if (Boolean.FALSE.equals(connected))
-					DropboxAuthorization.get().show();
-				else
-					new DropboxDialog(false).show();
-			}
-		}));
+		importFrom.addClickHandler(
+				event -> DropboxService.Instance.get().isConnected(new DefaultAsyncCallback<Boolean>() {
+					@Override
+					public void onSuccess(Boolean connected) {
+						if (Boolean.FALSE.equals(connected))
+							DropboxAuthorization.get().show();
+						else
+							new DropboxDialog(false).show();
+					}
+				}));
 
 		final MenuItem authrorize = new MenuItem(I18N.message(AUTHORIZE));
 		authrorize.addClickHandler(event -> DropboxAuthorization.get().show());
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/menu/QuickSearchTray.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/menu/QuickSearchTray.java
@@ -31,7 +31,7 @@ public class QuickSearchTray extends MenuTray {
 
 	private TextItem searchBox = new TextItem();
 
-	SelectItem searchType = new SelectItem();
+	private SelectItem searchType = new SelectItem();
 
 	public QuickSearchTray() {
 		FormItemIcon search = new FormItemIcon();
diff --git a/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/sharefile/ShareFileTree.java b/logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/sharefile/ShareFileTree.java
@@ -33,7 +33,10 @@ public ShareFileTree(boolean export) {
 		setCanAcceptDrop(false);
 		setCanAcceptDroppedRecords(false);
 		setShowRoot(false);
-
+		setSelectionAppearance(SelectionAppearance.CHECKBOX);  
+        setShowSelectedStyle(false);  
+        setShowPartialSelection(true);  
+		
 		if (export)
 			setSelectionType(SelectionStyle.SINGLE);
 		else {
diff --git a/logicaldoc-i18n/src/main/resources/i18n/messages.properties b/logicaldoc-i18n/src/main/resources/i18n/messages.properties
diff --git a/logicaldoc-webapp/src/main/resources/context.properties b/logicaldoc-webapp/src/main/resources/context.properties

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ public class InvalidSessionException extends AuthenticationException {`
`13`	`13`	`private final String sid;`
`14`	`14`
`15`	`15`	`public InvalidSessionException() {`
`16`		`- sid = null;`
	`16`	`+ sid = "";`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public InvalidSessionException(String sid) {`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ private void addModelsButton() {`
`33`	`33`	`addMember(models);`
`34`	`34`	`}`
`35`	`35`
`36`		`- if (Menu.enabled(Menu.ROBOTS)) {`
	`36`	`+ if (Menu.enabled(Menu.ADMIN_ROBOTS)) {`
`37`	`37`	`Button robots = new Button(I18N.message("robots"));`
`38`	`38`	`robots.setWidth100();`
`39`	`39`	`robots.setHeight(25);`