code fixes

Author: car031

logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/grid/RunningListGridField.java

@@ -12,22 +12,24 @@
  */
 public class RunningListGridField extends ColoredListGridField {
 
+	private static final String RUNNING = "running";
+
 	public RunningListGridField() {
-		super("running", " ", 30);
+		super(RUNNING, " ", 30);
 		setCanFilter(true);
 		setCanSort(true);
 		setCellFormatter((value, rec, rowNum, colNum) -> formatStatusIconCell(rec));
 	}
 
 	private String formatStatusIconCell(ListGridRecord rec) {
 		String color = rec.getAttributeAsString(colorFieldName);
-		Boolean running = rec.getAttributeAsBoolean("running");
+		Boolean running = rec.getAttributeAsBoolean(RUNNING);
 		if (running == null)
 			return "";
 
 		String content = "<div style='display: flex; text-align: center; justify-content: center;'>";
 		if (Boolean.TRUE.equals(running)) {
-			content += AwesomeFactory.getIconButtonHTML("cog", null, "running", color, "spin", null);
+			content += AwesomeFactory.getIconButtonHTML("cog", null, RUNNING, color, "spin", null);
 		} else {
 			content += AwesomeFactory.getIconButtonHTML("cog", null, "idle", color, null);
 		}

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/dashboard/messages/MessagePriorityListGridField.java

@@ -16,8 +16,10 @@
  */
 public class MessagePriorityListGridField extends ListGridField {
 
+	private static final String PRIORITY = "priority";
+
 	public MessagePriorityListGridField() {
-		super("priority", I18N.message("priority"));
+		super(PRIORITY, I18N.message(PRIORITY));
 		setCanFilter(true);
 		setCanSort(true);
 		setAlign(Alignment.CENTER);
@@ -28,7 +30,7 @@ public MessagePriorityListGridField() {
 
 	private String formatPriorityIconCell(ListGridRecord rec) {
 		String content = "<div style='display: flex; text-align: center; justify-content: center;'>";
-		int priority = rec.getAttributeAsInt("priority");
+		int priority = rec.getAttributeAsInt(PRIORITY);
 
 		switch (priority) {
 		case GUIMessage.PRIO_INFO:

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/document/BookmarksPanel.java

@@ -68,7 +68,7 @@ public void onDraw() {
 		list.setWidth100();
 		list.setHeight100();
 		list.setAutoFetchData(true);
-		list.setFields(name, description);
+		list.setFields(id, name, description);
 		list.setDataSource(new BookmarksDS());
 		list.setShowFilterEditor(true);
 		list.setFilterOnKeypress(true);

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/document/TrashPanel.java

@@ -76,7 +76,7 @@ public void onDraw() {
 		list.setWidth100();
 		list.setHeight100();
 		list.setAutoFetchData(true);
-		list.setFields(fileName, idField, customId, lastModified);
+		list.setFields(id, fileName, idField, customId, lastModified);
 		list.setSelectionType(SelectionStyle.MULTIPLE);
 		list.setDataSource(new GarbageDS());
 		list.setShowFilterEditor(true);

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/impex/archives/ArchiveStatusListGridField.java

@@ -17,8 +17,10 @@
  */
 public class ArchiveStatusListGridField extends ListGridField {
 
+	private static final String STATUS = "status";
+
 	public ArchiveStatusListGridField() {
-		super("status", I18N.message("status"));
+		super(STATUS, I18N.message(STATUS));
 		setAutoFitWidth(true);
 		setAutoFitWidthApproach(AutoFitWidthApproach.BOTH);
 		setAlign(Alignment.CENTER);
@@ -29,7 +31,7 @@ public ArchiveStatusListGridField() {
 
 	private String formatStatusIconCell(ListGridRecord rec) {
 		String content = "<div style='display: flex; text-align: center; justify-content: center;'>";
-		Integer status = rec.getAttributeAsInt("status");
+		Integer status = rec.getAttributeAsInt(STATUS);
 		Integer mode = rec.getAttributeAsInt("mode");
 		switch (status) {
 		case GUIArchive.STATUS_OPEN:

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/metadata/RetentionPoliciesPanel.java

@@ -40,7 +40,7 @@ public class RetentionPoliciesPanel extends AdminPanel {
 
 	private static final String ACTION = "action";
 
-	private static final String EENABLED = "eenabled";
+	private static final String ENABLED = "eenabled";
 
 	private static final String TEMPLATE = "template";
 
@@ -223,12 +223,12 @@ public void onSuccess(Void result) {
 
 		MenuItem enable = new MenuItem();
 		enable.setTitle(I18N.message("enable"));
-		enable.setEnabled(!rec.getAttributeAsBoolean("eenabled"));
+		enable.setEnabled(!rec.getAttributeAsBoolean(ENABLED));
 		enable.addClickHandler(event -> RetentionPoliciesService.Instance.get()
 				.changeStatus(Long.parseLong(rec.getAttributeAsString("id")), true, new DefaultAsyncCallback<>() {
 					@Override
 					public void onSuccess(Void result) {
-						rec.setAttribute(EENABLED, true);
+						rec.setAttribute(ENABLED, true);
 						list.refreshRow(list.getRecordIndex(rec));
 					}
 				}));
@@ -240,7 +240,7 @@ public void onSuccess(Void result) {
 				.changeStatus(Long.parseLong(rec.getAttributeAsString("id")), false, new DefaultAsyncCallback<>() {
 					@Override
 					public void onSuccess(Void result) {
-						rec.setAttribute(EENABLED, false);
+						rec.setAttribute(ENABLED, false);
 						list.refreshRow(list.getRecordIndex(rec));
 					}
 				}));

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/reports/TicketsReport.java

@@ -130,8 +130,8 @@ protected RefreshableListGrid createListGrid() {
 			protected String getCellCSSText(ListGridRecord rec, int rowNum, int colNum) {
 				if (Boolean.FALSE.equals(rec.getAttributeAsBoolean(VALID))
 						|| Boolean.FALSE.equals(rec.getAttributeAsBoolean(ENABLED))) {
-					return Boolean.TRUE.equals(rec.getAttributeAsBoolean(ENABLED) ? "color: #888888;" : "color: red;")
-							+ " font-style: italic;";
+					return Boolean.TRUE.equals(rec.getAttributeAsBoolean(ENABLED)) ? "color: #888888;"
+							: "color: red;" + " font-style: italic;";
 				} else {
 					return super.getCellCSSText(rec, rowNum, colNum);
 				}

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/security/ldap/LDAPServersPanel.java

@@ -41,6 +41,8 @@
  */
 public class LDAPServersPanel extends AdminPanel {
 
+	private static final String ENABLED = "eenabled";
+
 	private Layout detailsContainer = new VLayout();
 
 	private RefreshableListGrid list;
@@ -185,7 +187,7 @@ public void onSuccess(Void result) {
 
 		MenuItem enable = new MenuItem();
 		enable.setTitle(I18N.message("enable"));
-		enable.setEnabled(!rec.getAttributeAsBoolean("eenabled"));
+		enable.setEnabled(!rec.getAttributeAsBoolean(ENABLED));
 		enable.addClickHandler(event -> LDAPService.Instance.get().get(id, new DefaultAsyncCallback<>() {
 			@Override
 			public void onSuccess(GUILDAPServer server) {
@@ -204,7 +206,7 @@ public void onSuccess(GUILDAPServer v) {
 
 		MenuItem disable = new MenuItem();
 		disable.setTitle(I18N.message("disable"));
-		disable.setEnabled(rec.getAttributeAsBoolean("eenabled"));
+		disable.setEnabled(rec.getAttributeAsBoolean(ENABLED));
 		disable.addClickHandler(event -> LDAPService.Instance.get().get(id, new DefaultAsyncCallback<>() {
 			@Override
 			public void onSuccess(GUILDAPServer server) {
@@ -252,7 +254,7 @@ public void updateRecord(GUILDAPServer server) {
 
 		rec.setAttribute("url", server.getUrl());
 
-		rec.setAttribute("eenabled", server.isEnabled());
+		rec.setAttribute(ENABLED, server.isEnabled());
 
 		list.refreshRow(list.getRecordIndex(rec));
 	}

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/settings/searchindex/SearchIndexPanel.java

@@ -180,7 +180,7 @@ private Tab fillParsersTab() {
 		parsersList.setWidth100();
 		parsersList.setHeight100();
 		parsersList.setAutoFetchData(true);
-		parsersList.setFields(icon, extension, name, aliases);
+		parsersList.setFields(id, icon, extension, name, aliases);
 		parsersList.setDataSource(ParsersDS.get());
 		parsersList.setShowFilterEditor(true);
 		parsersList.setFilterOnKeypress(true);

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/tenant/TenantsPanel.java

@@ -39,6 +39,8 @@
  */
 public class TenantsPanel extends AdminPanel {
 
+	private static final String ENABLED = "eenabled";
+
 	private static final String ADDRESS = "address";
 
 	private static final String EMAIL = "email";
@@ -186,7 +188,7 @@ public void updateRecord(GUITenant tenant) {
 		rec.setAttribute("postalCode", tenant.getPostalCode());
 		rec.setAttribute("state", tenant.getState());
 		rec.setAttribute("expire", tenant.getExpire());
-		rec.setAttribute("eenabled", tenant.isEnabled());
+		rec.setAttribute(ENABLED, tenant.isEnabled());
 
 		list.refreshRow(list.getRecordIndex(rec));
 	}
@@ -225,7 +227,7 @@ public void onSuccess(Void result) {
 
 		MenuItem enable = new MenuItem();
 		enable.setTitle(I18N.message("enable"));
-		enable.setEnabled(!rec.getAttributeAsBoolean("eenabled"));
+		enable.setEnabled(!rec.getAttributeAsBoolean(ENABLED));
 		enable.addClickHandler(event -> TenantService.Instance.get().load(id, new DefaultAsyncCallback<>() {
 			@Override
 			public void onSuccess(GUITenant tenant) {
@@ -244,7 +246,7 @@ public void onSuccess(GUITenant v) {
 
 		MenuItem disable = new MenuItem();
 		disable.setTitle(I18N.message("disable"));
-		disable.setEnabled(rec.getAttributeAsBoolean("eenabled"));
+		disable.setEnabled(rec.getAttributeAsBoolean(ENABLED));
 		disable.addClickHandler(event -> TenantService.Instance.get().load(id, new DefaultAsyncCallback<>() {
 			@Override
 			public void onSuccess(GUITenant tenant) {