Merge pull request #17 from logicwind/dev

Dev

Author: bhavesh-lw

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.3.12
+
+- Resolved iOS crash related to trackEvent in React Native v0.74.
+- Updated readme.
+
 ## 0.3.11
 
 - Fixed Apple TVOS crash issue.

README.md

@@ -18,7 +18,14 @@ or using yarn:
 ```shell
 yarn add @logicwind/react-native-matomo-tracker
 ```
-Then follow the instructions for your platform to link @logicwind/react-native-matomo-tracker into your project:
+
+### Expo Setup
+
+If you're working with this Expo project, make sure to run:
+
+```sh md title="Terminal"
+npx expo prebuild
+```
 
 ### iOS installation
 

ios/ReactNativeMatomoTracker.mm

@@ -9,7 +9,7 @@ @interface RCT_EXTERN_MODULE(ReactNativeMatomoTracker, NSObject)
 
 RCT_EXTERN_METHOD(trackDispatch)
 
-RCT_EXTERN_METHOD(trackEvent:(NSString *)category withAction:(NSString *)action withName:(NSString *)name withValue:(NSNumber *)value withActionDimensions:(NSArray<NSDictionary *> *)actionDimensions)
+RCT_EXTERN_METHOD(trackEvent:(NSString *)category withAction:(NSString *)action withName:(NSString *)name withValue:(nonnull NSNumber *)value withActionDimensions:(NSArray<NSDictionary *> *)actionDimensions)
 
 RCT_EXTERN_METHOD(trackOutlink:(NSString *)url withActionDimensions:(NSArray<NSDictionary *> *)actionDimensions)
 
@@ -25,7 +25,7 @@ @interface RCT_EXTERN_MODULE(ReactNativeMatomoTracker, NSObject)
 
 RCT_EXTERN_METHOD(trackScreens)
 
-RCT_EXTERN_METHOD(trackGoal:(NSInteger)goalId withRevenue:(NSNumber *)revenue withActionDimensions:(NSArray<NSDictionary *> *)actionDimensions)
+RCT_EXTERN_METHOD(trackGoal:(NSInteger)goalId withRevenue:(nonnull NSNumber *)revenue withActionDimensions:(NSArray<NSDictionary *> *)actionDimensions)
 
 RCT_EXTERN_METHOD(setVisitorId:(NSString *)id)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@logicwind/react-native-matomo-tracker",
-  "version": "0.3.11",
+  "version": "0.3.12",
   "description": "React-native plugin for matomo analytics",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",