Skip to content

Commit 8e96172

Browse files
authored
Apply suggestions from code review
1 parent 925b7cb commit 8e96172

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 7.2.11
22
- Improved compatibility with the Elastic Common Schema [#206](https://github.com/logstash-plugins/logstash-filter-geoip/pull/206)
3-
- Added support for ECS's composite `region_iso_code`
3+
- Added support for ECS's composite `region_iso_code` (`US-WA`), which _replaces_ the non-ECS `region_code` (`WA`) as a default field with City databases. To get the stand-alone `region_code` in ECS mode, you must include it in the `fields` directive.
44
- [DOC] Improve ECS-related documentation
55

66
## 7.2.10

src/main/java/org/logstash/filters/geoip/GeoIPFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ private Map<Fields,Object> retrieveCityGeoData(InetAddress ipAddress) throws Geo
317317
if (countryCodeForRegion != null && regionCode2 != null) {
318318
geoData.put(Fields.REGION_ISO_CODE, String.format("%s-%s", countryCodeForRegion, regionCode2));
319319
}
320+
break;
320321
case TIMEZONE:
321322
String locationTimeZone = location.getTimeZone();
322323
if (locationTimeZone != null) {

0 commit comments

Comments
 (0)