Skip to content

Commit 770b6e9

Browse files
committed
Include timezone in ISO dates, test
1 parent a5b0796 commit 770b6e9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

logtail/frame.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# coding: utf-8
22
from __future__ import print_function, unicode_literals
3-
from datetime import datetime
3+
from datetime import datetime, timezone
44

55
from os import path
66
import __main__
77

88
def create_frame(record, message, context, include_extra_attributes=False):
99
r = record.__dict__
1010
frame = {}
11-
frame['dt'] = datetime.utcfromtimestamp(r['created']).isoformat()
11+
frame['dt'] = datetime.utcfromtimestamp(r['created']).replace(tzinfo=timezone.utc).isoformat()
1212
frame['level'] = level = _levelname(r['levelname'])
1313
frame['severity'] = int(r['levelno'] / 10)
1414
frame['message'] = message

tests/test_frame.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ def test_create_frame_happy_path(self):
1212
log_record = logging.LogRecord("logtail-test", 20, "/some/path", 10, "Some log message", [], None)
1313
frame = create_frame(log_record, log_record.getMessage(), LogtailContext())
1414
self.assertTrue(frame['level'] == 'info')
15+
# ISO timestamp must end with timezone info
16+
self.assertTrue(frame['dt'].endswith("+00:00"))
1517

1618
def test_create_frame_with_extra(self):
1719
handler = LogtailHandler(source_token="some-source-token")

0 commit comments

Comments
 (0)