Skip to content

Commit 4973531

Browse files
committed
T-4821 Avoid Rails methods in pure Ruby
1 parent 6993d4b commit 4973531

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

example-project/main.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
exit
1313
end
1414
# Create logger
15-
http_device = Logtail::LogDevices::HTTP.new(ARGV[0], ingesting_host: ARGV[1])
15+
http_device = Logtail::LogDevices::HTTP.new(ARGV[0], logtail_host: ARGV[1])
1616
logger = Logtail::Logger.new(http_device)
1717

1818
# Filter logs that shouldn't be sent to Better Stack, see {Logtail::LogEntry} for available attributes

lib/logtail/log_devices/http.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ class HTTP
6969
# Logtail::Logger.new(http_log_device)
7070
def initialize(source_token, options = {})
7171
# Handle backward-compatibility of argument names
72-
options[:ingesting_host] ||= options[:ingesting_host] if options[:ingesting_host].present?
73-
options[:ingesting_port] ||= options[:logtail_port] if options[:logtail_port].present?
74-
options[:ingesting_scheme] ||= options[:logtail_scheme] if options[:logtail_scheme].present?
72+
options[:ingesting_host] ||= options[:logtail_host]
73+
options[:ingesting_port] ||= options[:logtail_port]
74+
options[:ingesting_scheme] ||= options[:logtail_scheme]
7575

7676
@source_token = source_token || raise(ArgumentError.new("The source_token parameter cannot be blank"))
7777
@ingesting_host = options[:ingesting_host] || ENV['INGESTING_HOST'] || ENV['LOGTAIL_HOST'] || DEFAULT_INGESTING_HOST

0 commit comments

Comments
 (0)