feat(core): create multi custom domains (#7763)

Author: xiaoyijun

packages/core/src/routes/domain.test.ts

@@ -72,10 +72,10 @@ describe('domain routes', () => {
     expect(response.body.domain).toEqual('test.com');
   });
 
-  it('POST /domains should fail when there is already a domain', async () => {
-    await expect(
-      domainRequest.post('/domains').send({ domain: mockDomain.domain })
-    ).resolves.toHaveProperty('status', 422);
+  it('POST /domains allows creating multiple domains', async () => {
+    const response = await domainRequest.post('/domains').send({ domain: 'another.com' });
+    expect(response.status).toEqual(201);
+    expect(addDomain).toBeCalledWith('another.com');
   });
 
   it('DELETE /domains/:id', async () => {

packages/core/src/routes/domain.ts

@@ -6,6 +6,8 @@ import RequestError from '#src/errors/RequestError/index.js';
 import koaGuard from '#src/middleware/koa-guard.js';
 import assertThat from '#src/utils/assert-that.js';
 
+import { EnvSet } from '../env-set/index.js';
+
 import type { ManagementApiRouter, RouterInitArgs } from './types.js';
 
 export default function domainRoutes<T extends ManagementApiRouter>(
@@ -75,14 +77,16 @@ export default function domainRoutes<T extends ManagementApiRouter>(
       status: [201, 422, 400],
     }),
     async (ctx, next) => {
-      const existingDomains = await findAllDomains();
-      assertThat(
-        existingDomains.length === 0,
-        new RequestError({
-          code: 'domain.limit_to_one_domain',
-          status: 422,
-        })
-      );
+      if (!EnvSet.values.isDevFeaturesEnabled) {
+        const existingDomains = await findAllDomains();
+        assertThat(
+          existingDomains.length === 0,
+          new RequestError({
+            code: 'domain.limit_to_one_domain',
+            status: 422,
+          })
+        );
+      }
 
       // Throw 400 error if domain is invalid
       const syncedDomain = await addDomain(ctx.guard.body.domain);

packages/integration-tests/src/tests/api/domains.test.ts

@@ -1,7 +1,7 @@
 import { HTTPError } from 'ky';
 
 import { createDomain, deleteDomain, getDomain, getDomains } from '#src/api/domain.js';
-import { generateDomain } from '#src/utils.js';
+import { devFeatureDisabledTest, devFeatureTest, generateDomain } from '#src/utils.js';
 
 describe('domains', () => {
   afterEach(async () => {
@@ -23,13 +23,24 @@ describe('domains', () => {
     expect(domain.domain).toBe(domainName);
   });
 
-  it('should fail when already has a domain', async () => {
+  // Todo: @xiaoyijun [Multiple Custom Domains] Remove legacy tests
+  devFeatureDisabledTest.it('should fail when already has a domain', async () => {
     await createDomain();
 
     const response = await createDomain().catch((error: unknown) => error);
     expect(response instanceof HTTPError && response.response.status).toBe(422);
   });
 
+  // Todo: @xiaoyijun [Multiple Custom Domains] Remove legacy tests
+  devFeatureTest.it('should create multiple domains', async () => {
+    const first = await createDomain();
+    const second = await createDomain();
+
+    expect(first.id).toBeTruthy();
+    expect(second.id).toBeTruthy();
+    expect(first.id).not.toEqual(second.id);
+  });
+
   it('should get domain detail successfully', async () => {
     const createdDomain = await createDomain();
     const domain = await getDomain(createdDomain.id);