refactor(core): clean up experience migration logic (#7221)

* refactor(core): clean up experience migration logic

clean up experience package migration feature flag logic

* refactor(experience): remove experience-legacy

officially remove the experience-legay package

* chore: add changeset

add changeset

* chore: update changeset comment

update changeset comment

Author: simeng-li

.changeset/two-cheetahs-marry.md

@@ -0,0 +1,16 @@
+---
+"@logto/core": patch
+---
+
+clean up legacy experience package
+
+The migration to the new experience package is now complete, offering improved flexibility and maintainability through our Experience API. (see release [1.26.0](https://github.com/logto-io/logto/releases/tag/v1.26.0) for more details)
+
+Key updates:
+
+- Removed feature flags and migration-related logic
+- Cleaned up transitional code used during gradual rollout
+- Deprecated and removed `@logto/experience-legacy` package
+- Fully adopted `@logto/experience` package with Experience API for all user interactions
+
+This marks the completion of our authentication UI modernization, providing a more maintainable and extensible foundation for future enhancements.

package.json

@@ -10,7 +10,7 @@
     "prepack": "pnpm -r prepack",
     "dev": "pnpm -r prepack && pnpm start:dev",
     "dev:cloud": "IS_CLOUD=1 CONSOLE_PUBLIC_URL=/ pnpm dev",
-    "start:dev": "pnpm -r --parallel --filter=!@logto/integration-tests --filter=!@logto/experience-legacy --filter \"!./packages/connectors/connector-*\" dev",
+    "start:dev": "pnpm -r --parallel --filter=!@logto/integration-tests --filter \"!./packages/connectors/connector-*\" dev",
     "start": "cd packages/core && NODE_ENV=production node .",
     "cli": "logto",
     "translate": "logto-translate",

packages/core/package.json

@@ -39,7 +39,6 @@
     "@logto/core-kit": "workspace:^2.5.4",
     "@logto/demo-app": "workspace:*",
     "@logto/experience": "workspace:*",
-    "@logto/experience-legacy": "workspace:*",
     "@logto/js": "^5.0.3",
     "@logto/language-kit": "workspace:^1.1.3",
     "@logto/phrases": "workspace:^1.18.0",

packages/core/src/middleware/koa-spa-proxy.ts

@@ -1,8 +1,7 @@
 import fs from 'node:fs/promises';
 import path from 'node:path';
 
-import { type Nullable, trySafe } from '@silverhand/essentials';
-import type { Context, MiddlewareType } from 'koa';
+import type { MiddlewareType } from 'koa';
 import proxy from 'koa-proxies';
 import type { IRouterParamContext } from 'koa-router';
 
@@ -12,7 +11,6 @@ import type Queries from '#src/tenants/Queries.js';
 import { getConsoleLogFromContext } from '#src/utils/console.js';
 
 import serveCustomUiAssets from './koa-serve-custom-ui-assets.js';
-import { getExperiencePackageWithFeatureFlagDetection } from './utils/experience-proxy.js';
 
 type Properties = {
   readonly mountedApps: string[];
@@ -22,22 +20,6 @@ type Properties = {
   readonly prefix?: string;
 };
 
-const getDistributionPath = async <ContextT extends Context>(
-  packagePath: string,
-  ctx: ContextT
-): Promise<[string, string]> => {
-  if (packagePath === 'experience') {
-    // Safely get the experience package name with feature flag detection, default fallback to legacy
-    const moduleName =
-      (await trySafe(async () => getExperiencePackageWithFeatureFlagDetection(ctx))) ??
-      'experience-legacy';
-
-    return [path.join('node_modules/@logto', moduleName, 'dist'), moduleName];
-  }
-
-  return [path.join('node_modules/@logto', packagePath, 'dist'), packagePath];
-};
-
 export default function koaSpaProxy<StateT, ContextT extends IRouterParamContext, ResponseBodyT>({
   mountedApps,
   packagePath = 'experience',
@@ -47,9 +29,10 @@ export default function koaSpaProxy<StateT, ContextT extends IRouterParamContext
 }: Properties): MiddlewareType<StateT, ContextT, ResponseBodyT> {
   type Middleware = MiddlewareType<StateT, ContextT, ResponseBodyT>;
 
-  // Avoid defining a devProxy if we are in production
-  const devProxy: Nullable<Middleware> = EnvSet.values.isProduction
-    ? null
+  const distributionPath = path.join('node_modules/@logto', packagePath, 'dist');
+
+  const spaProxy: Middleware = EnvSet.values.isProduction
+    ? serveStatic(distributionPath)
     : proxy('*', {
         target: `http://localhost:${port}`,
         changeOrigin: true,
@@ -58,7 +41,6 @@ export default function koaSpaProxy<StateT, ContextT extends IRouterParamContext
           if (path.basename(ctx.request.path).includes('.')) {
             return;
           }
-
           getConsoleLogFromContext(ctx).plain(`\tproxy --> ${target}`);
         },
         rewrite: (requestPath) => {
@@ -68,35 +50,30 @@ export default function koaSpaProxy<StateT, ContextT extends IRouterParamContext
 
   return async (ctx, next) => {
     const requestPath = ctx.request.path;
-
     // Skip if the request is for another app
     if (!prefix && mountedApps.some((app) => app !== prefix && requestPath.startsWith(`/${app}`))) {
       return next();
     }
-
     const { customUiAssets } = await queries.signInExperiences.findDefaultSignInExperience();
-
     // If user has uploaded custom UI assets, serve them instead of native experience UI
     if (customUiAssets && packagePath === 'experience') {
       const serve = serveCustomUiAssets(customUiAssets.id);
       return serve(ctx, next);
     }
 
-    // Use the devProxy under development mode
-    if (devProxy) {
-      return devProxy(ctx, next);
+    if (!EnvSet.values.isProduction) {
+      return spaProxy(ctx, next);
     }
 
-    const [distributionPath, moduleName] = await getDistributionPath(packagePath, ctx);
     const spaDistributionFiles = await fs.readdir(distributionPath);
 
     if (!spaDistributionFiles.some((file) => requestPath.startsWith('/' + file))) {
       ctx.request.path = '/';
     }
 
     // Add a header to indicate which static package is being served
-    ctx.set('Logto-Static-Package', moduleName);
+    ctx.set('Logto-Static-Package', packagePath);
 
-    return serveStatic(distributionPath)(ctx, next);
+    return spaProxy(ctx, next);
   };
 }