Skip to content

Commit 94ccd30

Browse files
committed
Update ruby tests
1 parent 61b0e3d commit 94ccd30

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

e2e_tests/e2e_metric_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ func TestE2EMetrics(t *testing.T) {
2626
// may be disabled by default. Make the HTTP client metric optional for Java runtime.
2727
isJava := os.Getenv("EXPECTED_LAMBDA_FUNCTION_NAME") == "one-layer-e2e-test-java" ||
2828
os.Getenv("EXPECTED_SERVICE_NAME") == "logzio-e2e-java-service"
29-
if !isJava {
29+
// Ruby's E2E may not emit http_client metrics consistently; keep it optional like Java.
30+
isRuby := os.Getenv("EXPECTED_LAMBDA_FUNCTION_NAME") == "one-layer-e2e-test-ruby" ||
31+
os.Getenv("EXPECTED_SERVICE_NAME") == "logzio-e2e-ruby-service"
32+
if !isJava && !isRuby {
3033
metricsToCheck = append(metricsToCheck, "http_client_duration_milliseconds_count")
3134
}
3235

e2e_tests/e2e_trace_test.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ func TestE2ETraces(t *testing.T) {
2727
isJava := os.Getenv("EXPECTED_LAMBDA_FUNCTION_NAME") == "one-layer-e2e-test-java" ||
2828
os.Getenv("EXPECTED_SERVICE_NAME") == "logzio-e2e-java-service"
2929

30+
// Ruby Net::HTTP instrumentation may emit internal spans (e.g., "connect").
31+
// Accept either client spans or internal spans specifically from Net::HTTP.
32+
isRuby := os.Getenv("EXPECTED_LAMBDA_FUNCTION_NAME") == "one-layer-e2e-test-ruby" ||
33+
os.Getenv("EXPECTED_SERVICE_NAME") == "logzio-e2e-ruby-service"
34+
3035
baseQueryWithFaas := fmt.Sprintf(`type:jaegerSpan AND process.serviceName:"%s" AND process.tag.faas@name:"%s"`, expectedServiceName, expectedFaasName)
3136
baseQueryServiceOnly := fmt.Sprintf(`type:jaegerSpan AND process.serviceName:"%s"`, expectedServiceName)
3237

@@ -48,7 +53,12 @@ func TestE2ETraces(t *testing.T) {
4853
// Relax for Java: some client spans may not carry faas.name
4954
clientBase = baseQueryServiceOnly
5055
}
51-
clientQuery := clientBase + " AND JaegerTag.span@kind:client"
56+
var clientQuery string
57+
if isRuby {
58+
clientQuery = clientBase + " AND (JaegerTag.span@kind:client OR (JaegerTag.span@kind:internal AND JaegerTag.otel@scope@name:\"OpenTelemetry::Instrumentation::Net::HTTP\"))"
59+
} else {
60+
clientQuery = clientBase + " AND JaegerTag.span@kind:client"
61+
}
5262
e2eLogger.Infof("Querying for client spans: %s", clientQuery)
5363
clientResp, err := fetchLogzSearchAPI(t, tracesQueryKey, logzioAPIURL, clientQuery, "traces")
5464
require.NoError(t, err, "Failed to find client spans after all retries.")

0 commit comments

Comments
 (0)