Merge branch 'master' of https://github.com/loiane/javascript-datastructures-algorithms into third-edition

Author: loiane

package-lock.json

@@ -30,7 +30,8 @@
     "generate-report": "nyc --report-dir coverage npm run test && nyc report --reporter=text",
     "generate-report2": "nyc --report-dir coverage npm run test",
     "go": "npm run clean && npm run lint && npm run build && npm run test",
-    "webpack": "webpack --env build"
+    "webpack": "webpack --env build",
+    "serve" :"http-server"
   },
   "nyc": {
     "include": [
@@ -54,7 +55,7 @@
   },
   "devDependencies": {
     "@types/chai": "^4.1.2",
-    "@types/mocha": "^5.0.0",
+    "@types/mocha": "^5.2.0",
     "babel-cli": "^6.26.0",
     "babel-core": "^6.26.0",
     "babel-eslint": "^8.2.2",
@@ -70,12 +71,15 @@
     "istanbul": "^v1.1.0-alpha.1",
     "mocha": "^5.0.4",
     "mochawesome": "^3.0.2",
-    "nyc": "^11.6.0",
+    "nyc": "11.7.0",
     "ts-node": "^5.0.1",
     "tslint": "^5.9.1",
     "typescript": "^2.7.2",
     "webpack": "^4.1.1",
-    "webpack-cli": "^2.0.12",
+    "webpack-cli": "2.0.14",
     "yargs": "^11.0.0"
+  },
+  "dependencies": {
+    "http-server": "^0.11.1"
   }
 }

package.json

@@ -4,18 +4,15 @@ function partition(array, left, right, compareFn) {
   const pivot = array[Math.floor((right + left) / 2)];
   let i = left;
   let j = right;
-  // console.log('pivot is ' + pivot + '; left is ' + left + '; right is ' + right);
+  
   while (i <= j) {
     while (compareFn(array[i], pivot) === Compare.LESS_THAN) {
       i++;
-      // console.log('i = ' + i);
     }
     while (compareFn(array[j], pivot) === Compare.BIGGER_THAN) {
       j--;
-      // console.log('j = ' + j);
     }
     if (i <= j) {
-      // console.log('swap ' + array[i] + ' with ' + array[j]);
       swap(array, i, j);
       i++;
       j--;

src/js/algorithms/sorting/quicksort.js

@@ -11,7 +11,7 @@ export function parenthesesChecker(symbols) {
   let top;
 
   while (index < symbols.length && balanced) {
-    symbol = symbols.charAt(index);
+    symbol = symbols[index];
     if (opens.indexOf(symbol) >= 0) {
       stack.push(symbol);
     } else if (stack.isEmpty()) {
@@ -24,8 +24,5 @@ export function parenthesesChecker(symbols) {
     }
     index++;
   }
-  if (balanced && stack.isEmpty()) {
-    return true;
-  }
-  return false;
+  return balanced && stack.isEmpty();
 }

src/js/others/balanced-symbols.js

@@ -26,7 +26,6 @@ export function fibonacciMemoization(n) {
   const memo = [0, 1];
   const fibonacciMem = num => {
     if (memo[num] != null) { return memo[num]; }
-    memo[num] = fibonacciMem(num - 1) + fibonacciMem(num - 2);
     return (memo[num] = fibonacciMem(num - 1) + fibonacciMem(num - 2));
   };
   return fibonacciMem(n);

src/js/others/fibonacci.js

@@ -10,21 +10,20 @@ export function palindromeChecker(aString) {
   }
   const deque = new Deque();
   const lowerString = aString.toLocaleLowerCase().split(' ').join('');
-  let isEqual = true;
   let firstChar;
   let lastChar;
 
   for (let i = 0; i < lowerString.length; i++) {
     deque.addBack(lowerString.charAt(i));
   }
 
-  while (deque.size() > 1 && isEqual) {
+  while (deque.size() > 1) {
     firstChar = deque.removeFront();
     lastChar = deque.removeBack();
     if (firstChar !== lastChar) {
-      isEqual = false;
+      return false;
     }
   }
 
-  return isEqual;
+  return true;
 }

src/js/others/palindrome-checker.js

@@ -18,7 +18,7 @@ export function biggerEquals(a, b, compareFn) {
 
 export function defaultCompare(a, b) {
   if (a === b) {
-    return 0;
+    return Compare.EQUALS;
   }
   return a < b ? Compare.LESS_THAN : Compare.BIGGER_THAN;
 }

src/js/util.js

@@ -13,25 +13,14 @@ export function parenthesesChecker(symbols: string) {
     symbol = symbols[index];
     if (opens.indexOf(symbol) >= 0) {
       stack.push(symbol);
-      // console.log(`open symbol - stacking ${symbol}`);
     } else {
-      // console.log(`close symbol ${symbol}`);
       if (stack.isEmpty()) {
         balanced = false;
-        // console.log('Stack is empty, no more symbols to pop and compare');
       } else {
         top = stack.pop();
-        // if (!matches(top, symbol)){
         if (!(opens.indexOf(top) === closers.indexOf(symbol))) {
           balanced = false;
-          /* console.log(
-            `poping symbol ${top} - is not a match compared to ${symbol}`
-          ); */
-        } /* else {
-          console.log(
-            `poping symbol ${top} - is is a match compared to ${symbol}`
-          );
-        } */
+        } 
       }
     }
     index++;

src/ts/others/balanced-symbols.ts

@@ -4,7 +4,7 @@ export function factorialIterative(number: number) {
   }
   let total = 1;
   for (let n = number; n > 1; n--) {
-    total  = total * n;
+    total  *= n;
   }
   return total;
 }

src/ts/others/factorial.ts

@@ -9,20 +9,19 @@ export function palindromeChecker(aString: string) {
 
   const deque = new Deque<string>();
   const lowerString = aString.toLocaleLowerCase().split(' ').join('');
-  let isEqual = true;
   let firstChar: string, lastChar: string;
 
   for (let i = 0; i < lowerString.length; i++) {
     deque.addBack(lowerString.charAt(i));
   }
 
-  while (deque.size() > 1 && isEqual) {
+  while (deque.size() > 1) {
     firstChar = deque.removeFront();
     lastChar = deque.removeBack();
     if (firstChar !== lastChar) {
-      isEqual = false;
+      return false;
     }
   }
 
-  return isEqual;
+  return true;
 }