ci: fix linting issues from staticheck (#117)

Author: loicsikidi

cmd/bundle/verify/display.go

@@ -163,13 +163,13 @@ func displayAttestationMetadata(vr *verify.VerificationResult) string {
 	}
 
 	// Build output
-	sb.WriteString(fmt.Sprintf("  - Build repo:..... %s\n", buildRepo))
-	sb.WriteString(fmt.Sprintf("  - Build workflow:. %s\n", buildWorkflow))
-	sb.WriteString(fmt.Sprintf("  - Git commit:..... %s\n", gitCommit))
-	sb.WriteString(fmt.Sprintf("  - Signer repo:.... %s\n", signerRepo))
-	sb.WriteString(fmt.Sprintf("  - Signer workflow: %s\n", signerWorkflow))
+	fmt.Fprintf(&sb, "  - Build repo:..... %s\n", buildRepo)
+	fmt.Fprintf(&sb, "  - Build workflow:. %s\n", buildWorkflow)
+	fmt.Fprintf(&sb, "  - Git commit:..... %s\n", gitCommit)
+	fmt.Fprintf(&sb, "  - Signer repo:.... %s\n", signerRepo)
+	fmt.Fprintf(&sb, "  - Signer workflow: %s\n", signerWorkflow)
 	if rekorTimestamp != "" {
-		sb.WriteString(fmt.Sprintf("  - Rekor timestamp: %s\n", rekorTimestamp))
+		fmt.Fprintf(&sb, "  - Rekor timestamp: %s\n", rekorTimestamp)
 	}
 
 	return sb.String()

internal/bundle/generator.go

@@ -234,16 +234,16 @@ func buildCertificateHeader(cert *x509.Certificate, name string, vendorID string
 
 	var header strings.Builder
 	header.WriteString("#\n")
-	header.WriteString(fmt.Sprintf("# Certificate: %s\n", name))
-	header.WriteString(fmt.Sprintf("# Owner: %s\n", vendorID))
+	fmt.Fprintf(&header, "# Certificate: %s\n", name)
+	fmt.Fprintf(&header, "# Owner: %s\n", vendorID)
 	header.WriteString("#\n")
-	header.WriteString(fmt.Sprintf("# Issuer: %s\n", cert.Issuer.String()))
-	header.WriteString(fmt.Sprintf("# Serial Number: %d (%#x)\n", cert.SerialNumber, cert.SerialNumber))
-	header.WriteString(fmt.Sprintf("# Subject: %s\n", cert.Subject.String()))
-	header.WriteString(fmt.Sprintf("# Not Valid Before: %s\n", cert.NotBefore.Format("Mon Jan 02 15:04:05 2006")))
-	header.WriteString(fmt.Sprintf("# Not Valid After : %s\n", cert.NotAfter.Format("Mon Jan 02 15:04:05 2006")))
-	header.WriteString(fmt.Sprintf("# Fingerprint (SHA-256): %s\n", formatFingerprint(sha256Hash[:])))
-	header.WriteString(fmt.Sprintf("# Fingerprint (SHA1): %s\n", formatFingerprint(sha1Hash[:])))
+	fmt.Fprintf(&header, "# Issuer: %s\n", cert.Issuer.String())
+	fmt.Fprintf(&header, "# Serial Number: %d (%#x)\n", cert.SerialNumber, cert.SerialNumber)
+	fmt.Fprintf(&header, "# Subject: %s\n", cert.Subject.String())
+	fmt.Fprintf(&header, "# Not Valid Before: %s\n", cert.NotBefore.Format("Mon Jan 02 15:04:05 2006"))
+	fmt.Fprintf(&header, "# Not Valid After : %s\n", cert.NotAfter.Format("Mon Jan 02 15:04:05 2006"))
+	fmt.Fprintf(&header, "# Fingerprint (SHA-256): %s\n", formatFingerprint(sha256Hash[:]))
+	fmt.Fprintf(&header, "# Fingerprint (SHA1): %s\n", formatFingerprint(sha1Hash[:]))
 
 	return header.String()
 }
@@ -272,23 +272,23 @@ func buildBundleHeader(outputPath, date, commit string, bundleType BundleType) s
 
 	if outputPath != "" {
 		filename := filepath.Base(outputPath)
-		header.WriteString(fmt.Sprintf("## %s\n", filename))
+		fmt.Fprintf(&header, "## %s\n", filename)
 	} else {
-		header.WriteString(fmt.Sprintf("## %s\n", bundleType.DefaultFilename()))
+		fmt.Fprintf(&header, "## %s\n", bundleType.DefaultFilename())
 	}
 
 	header.WriteString("##\n")
 
 	if date != "" {
-		header.WriteString(fmt.Sprintf("## Date: %s\n", date))
+		fmt.Fprintf(&header, "## Date: %s\n", date)
 	}
 	if commit != "" {
-		header.WriteString(fmt.Sprintf("## Commit: %s\n", commit))
+		fmt.Fprintf(&header, "## Commit: %s\n", commit)
 	}
 
 	header.WriteString("##\n")
 	header.WriteString("## This file has been auto-generated by tpmtb (TPM Trust Bundle)\n")
-	header.WriteString(fmt.Sprintf("## and contains a list of verified %s.\n", bundleType.Description()))
+	fmt.Fprintf(&header, "## and contains a list of verified %s.\n", bundleType.Description())
 	header.WriteString("##\n")
 	header.WriteString("\n")
 	return header.String()

internal/config/sanity/sanity.go

@@ -24,9 +24,9 @@ type ValidationError struct {
 
 func (e ValidationError) String() string {
 	var b strings.Builder
-	b.WriteString(fmt.Sprintf("  Vendor: %s (%s)\n", e.VendorName, e.VendorID))
-	b.WriteString(fmt.Sprintf("  Certificate: %s\n", e.CertName))
-	b.WriteString(fmt.Sprintf("  Error: %s\n", e.Error))
+	fmt.Fprintf(&b, "  Vendor: %s (%s)\n", e.VendorName, e.VendorID)
+	fmt.Fprintf(&b, "  Certificate: %s\n", e.CertName)
+	fmt.Fprintf(&b, "  Error: %s\n", e.Error)
 	return b.String()
 }
 
@@ -42,12 +42,12 @@ type ExpirationWarning struct {
 
 func (w ExpirationWarning) String() string {
 	var b strings.Builder
-	b.WriteString(fmt.Sprintf("  Vendor: %s (%s)\n", w.VendorName, w.VendorID))
-	b.WriteString(fmt.Sprintf("  Certificate: %s\n", w.CertName))
+	fmt.Fprintf(&b, "  Vendor: %s (%s)\n", w.VendorName, w.VendorID)
+	fmt.Fprintf(&b, "  Certificate: %s\n", w.CertName)
 	if w.IsExpired {
-		b.WriteString(fmt.Sprintf("  Status: Expired on %s\n", w.ExpiryDate.Format("2006-01-02")))
+		fmt.Fprintf(&b, "  Status: Expired on %s\n", w.ExpiryDate.Format("2006-01-02"))
 	} else {
-		b.WriteString(fmt.Sprintf("  Status: Expires in %d days (%s)\n", w.DaysLeft, w.ExpiryDate.Format("2006-01-02")))
+		fmt.Fprintf(&b, "  Status: Expires in %d days (%s)\n", w.DaysLeft, w.ExpiryDate.Format("2006-01-02"))
 	}
 	return b.String()
 }