fix(lesy-plugin-validator): return middleware data

Author: lokesh-coder

packages/plugins/lesy-plugin-validator/__tests__/validator.middleware.test.ts

@@ -12,8 +12,6 @@ describe("@lesy/lesy-plugin-validator", () => {
       commands: [
         {
           name: "hello",
-          description: "this is hello desc",
-          usage: "--foo--",
           args: {
             name: {
               required: true,
@@ -24,6 +22,15 @@ describe("@lesy/lesy-plugin-validator", () => {
             console.log(`Hello ${args.name}`);
           },
         },
+        {
+          name: "sayname",
+          args: {
+            name: {},
+          },
+          run: ({ args }) => {
+            console.log(`Hi ${args.name || "Stranger"}`);
+          },
+        },
       ],
       middlewares: [resolve(__dirname, "../src/validator.middleware.ts")],
     });
@@ -53,4 +60,9 @@ describe("@lesy/lesy-plugin-validator", () => {
     const response = await testBed.run(["hello"]);
     expect(response).toContain("Hello yogo");
   });
+
+  it("should not prompt for non required aargs", async () => {
+    const response = await testBed.run(["sayname"]);
+    expect(response).toContain("Hi Stranger");
+  });
 });

packages/plugins/lesy-plugin-validator/src/validator.middleware.ts

@@ -1,11 +1,11 @@
 export default {
   on: "PRE_VALIDATE",
-  async run({ runningCommand: cmd, args, feature }) {
-    console.log("***", feature);
+  async run(ctx) {
+    const { runningCommand: cmd, args, feature } = ctx;
     const missingValues = [];
-    let newArgs = cmd.args;
+    let newArgs = args;
     Object.keys(cmd.args).forEach((key: any) => {
-      if (!args[key]) {
+      if (cmd.args[key].required && !args[key]) {
         missingValues.push(key);
       }
     });
@@ -27,6 +27,7 @@ export default {
       const ans = await feature.prompt(questions);
       newArgs = { ...args, ...ans };
     }
-    return { cmd, args: newArgs };
+    ctx.args = newArgs;
+    return ctx;
   },
 };