Bugfix - MaxHeight wouldn't work.

bugsbyteyou · web-flow · commit 7e6db1c58b46 · 2016-12-07T20:47:59.000Z
Seems like there is a bug in line 306, the code is comparing against width but we want height.
diff --git a/src/js/lightbox.js b/src/js/lightbox.js
@@ -302,7 +302,7 @@
         if (self.options.maxWidth && self.options.maxWidth < maxImageWidth) {
           maxImageWidth = self.options.maxWidth;
         }
-        if (self.options.maxHeight && self.options.maxHeight < maxImageWidth) {
+        if (self.options.maxHeight && self.options.maxHeight < maxImageHeight) {
           maxImageHeight = self.options.maxHeight;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@`
`302`	`302`	`if (self.options.maxWidth && self.options.maxWidth < maxImageWidth) {`
`303`	`303`	`maxImageWidth = self.options.maxWidth;`
`304`	`304`	`}`
`305`		`- if (self.options.maxHeight && self.options.maxHeight < maxImageWidth) {`
	`305`	`+ if (self.options.maxHeight && self.options.maxHeight < maxImageHeight) {`
`306`	`306`	`maxImageHeight = self.options.maxHeight;`
`307`	`307`	`}`
`308`	`308`