FRC Code Review

[Jz-0409]

COMMENTS
Hello, we've reviewed your Repulsor code.
From what we could see, there are many constants used in your code that are hardcoded (ex: in distToForceMag, you added 0.00001), which we assume is intentional. Maybe you could make these a constant variable so that if you adjust the values later, you reduce the risk of unmatched values. We really couldn't find anything to critique, as your code appears error-free.

SUGGESTION
All we have to say is that for the next time you write code, add more comments for situations like this review. (Especially in such a complex and detailed program where the readers are inexperienced-like us)

We wish we could offer more detailed feedback, but again, everything looks well coded! Good job and good luck next season.

[Hydro-gen1]

Hi Team 7127. Our team 9644 has reviewed your RepulsorFieldPlanner code.

For what we can infer as the use of this code, being a path planning system utilizing force, it seems to effectively fulfill its purpose. It seems to effectively generate mathematically correct shapes to serve as force obstacles. Similar to the last reviewer I have the same critiques. I found that the constants could be either centralized to the Constants file or at the least be constant variables within the function or class overall. For example, the division by 0.00001 in distToForceMag could be moved to constants since it's utilized to not divide by zero which could come in handy later on within your code base.

In the future, I would add significantly more comments as to any outsiders, such as us reviewers, it can be difficult to understand and read what the contents of your program are in one as complex as this. Otherwise, everything within this program seems well coded and we wish you luck in the next season!