Skip to content

Commit 098927d

Browse files
author
Luke Bowerman
authored
test: Refinements to FieldPicker story (#2400)
1 parent b89822b commit 098927d

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

packages/components/src/Tree/stories/FieldItem.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ import { listItemDimensions } from '../../List'
4444

4545
type FieldItemProps = {
4646
color?: ToggleColor
47-
truncate?: boolean
4847
filter?: boolean
4948
pivot?: boolean
5049
selected?: boolean
@@ -57,21 +56,22 @@ export const FieldItem: FC<FieldItemProps> = ({
5756
pivot = false,
5857
selected = false,
5958
}) => {
60-
const [overlay, setOverlay] = useState<string | undefined>(undefined)
59+
const [isFieldMenuOpen, setIsFieldMenuOpen] = useState<boolean>(false)
6160

6261
const [isFilter, setIsFilter] = useState(filter)
6362
const [isPivot, setIsPivot] = useState(pivot)
6463
const [isSelected, setIsSelected] = useState(selected)
6564

6665
const toggleMenu = () =>
67-
overlay === 'menu' ? setOverlay(undefined) : setOverlay('menu')
66+
isFieldMenuOpen ? setIsFieldMenuOpen(false) : setIsFieldMenuOpen(true)
67+
6868
const detailContent = (
6969
<>
7070
<Tooltip placement="top" content="Some exciting info or something">
7171
<IconButton icon={<Info />} label="Info" />
7272
</Tooltip>
7373
<Menu
74-
isOpen={overlay === 'menu'}
74+
isOpen={isFieldMenuOpen}
7575
setOpen={toggleMenu}
7676
density={-1}
7777
content={
@@ -103,16 +103,18 @@ export const FieldItem: FC<FieldItemProps> = ({
103103
content: detailContent,
104104
options: {
105105
accessory: true,
106-
hoverDisclosure: !overlay,
106+
hoverDisclosure: !isFieldMenuOpen,
107107
},
108108
}}
109-
itemRole="none"
110-
onClickWhitespace={toggleField}
111109
onKeyDown={(event) => {
112110
if (event.key === 'Enter' && event.metaKey) {
113111
alert(`CMD + Enter'ed on ${children}!`)
112+
} else if (event.key === 'Enter') {
113+
toggleField()
114114
}
115115
}}
116+
itemRole="none"
117+
onClickWhitespace={toggleField}
116118
>
117119
<Flex alignItems="center" pl="xxsmall">
118120
<Flex

0 commit comments

Comments
 (0)