fix(Text): Text should not have default color and lineHeight based on fontSize (#1813)

Added Jest and Storybook image-snaoshots to prevent future regressions

Author: Luke Bowerman

packages/components/snapshots/Text/Basic-snap.png

@@ -0,0 +1,53 @@
+/*
+
+ MIT License
+
+ Copyright (c) 2020 Looker Data Sciences, Inc.
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to deal
+ in the Software without restriction, including without limitation the rights
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
+
+ */
+
+import React from 'react'
+import { Story } from '@storybook/react/types-6-0'
+import { Text, TextProps } from './Text'
+
+const Template: Story<TextProps> = (args) => <Text {...args} />
+
+export const Basic = Template.bind({})
+Basic.args = {
+  children: 'Text Example',
+}
+
+export const Nesting = () => (
+  <div style={{ color: '#c00' }}>
+    <Text>This text should be red</Text>
+  </div>
+)
+
+export const LineHeight = () => (
+  <div style={{ border: '1px solid #000' }}>
+    <Text>This text should be 1.5rem line height</Text>
+  </div>
+)
+
+export default {
+  component: Text,
+  title: 'Text',
+}

packages/components/snapshots/Text/Line Height-snap.png

@@ -31,5 +31,7 @@ import { Text } from './Text'
 
 test('Text has default fontSize', () => {
   renderWithTheme(<Text>Hello</Text>)
-  expect(screen.getByText('Hello')).toHaveStyleRule('font-size: 16px')
+  expect(screen.getByText('Hello')).toHaveStyleRule('font-size', '1rem')
+  expect(screen.getByText('Hello')).toHaveStyleRule('line-height', '1.5rem')
+  expect(screen.getByText('Hello')).toHaveStyleRule('color', undefined)
 })

packages/components/snapshots/Text/Nesting-snap.png

@@ -31,8 +31,8 @@ import { Span, SpanProps } from './Span'
 export interface TextProps extends SpanProps {}
 
 export const Text = styled(Span).attrs<TextProps>(
-  ({ color = 'text', fontSize = 'medium' }) => ({
-    color,
+  ({ fontSize = 'medium', lineHeight }) => ({
     fontSize,
+    lineHeight: lineHeight || fontSize,
   })
 )<TextProps>``