Skip to content

Commit 2818376

Browse files
Luke Bowermanlaraharrowmdodgelooker
authored
Refactor ActionList to improve a11y / IE11, enrich and improve (#1474)
* Major refactor of ActionList * Use <table> for ActionList to improve a11y / IE11 * ActionList code shuffle * ColumnSelector is now its own component and it displays a popover when clicked * Allow icon for label * Improved :focus presentation * Moved mock data to __mock__ folder * Apply / Cancel buttons on Popover * Remove header property (you get what you get) * Fix `columnsToDisplay` typing in context * Update packages/components/src/ActionList/ActionList.tsx Co-authored-by: Lara Harrow <[email protected]> Co-authored-by: mdodgelooker <[email protected]>
1 parent 4b74ac9 commit 2818376

File tree

87 files changed

+1997
-987
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+1997
-987
lines changed

.vscode/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"labeledby",
3131
"labelledby",
3232
"nomarker",
33+
"nowrap",
3334
"polarbrightness",
3435
"popperjs",
3536
"scrollbar",

packages/components/CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Added
1111

12+
- `ActionList` got a major refactor
13+
- Columns now support `size`
14+
- If `small`, `medium` or `large` is specified the content will be truncated to fit
15+
- If `nowrap` column will not wrap white-space and will grow fit content width
16+
- Responsive support - if table exceeds viewport width it will scroll sideways
17+
- `firstColumnStuck` developer can specify if the first column should "stick" to the viewport edge when scrolling
18+
- NOTE: Column for checkbox selection and actions column are always stuck to their respective edges
19+
- Column selection - the user can select which columns are displayed (if any columns have `hide` specified in their configuration)
1220
- The `autoFocus` prop will now work for inputs in `Popover` and `Dialog`
1321
- `Select`, `SelectMulti`, `InputTimeSelect`, and `InputSearch` now support `autoFocus`
1422
- `Dialog` & `Drawer` now support semantic sizes (`xxsmall - xlarge`)
@@ -17,6 +25,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1725

1826
### Changed
1927

28+
- `ActionList` got a major refactor
29+
- Now uses a `table` element instead of previous grid layout (IE11 compatible)
30+
- Vertical cadence of `ActionList` reduced to a minimum of `36px`
2031
- `Popover`, `Menu`, and `Select` no longer cancel the first click outside by default (use `cancelClickOutside` to override this)
2132
- `DialogContent` no longer has `py` unless it overflows the available space (acting as `overflow: scroll`)
2233

@@ -35,6 +46,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3546

3647
### Removed
3748

49+
- `ActionList` no longer supports `header` prop (header is always generated by component now)
50+
- `column` no longer supports `width` (see new `size` behavior)
3851
- `groupedPopoversRef` and `groupedMenusRef` (`Popover` and `Menu` no longer cancel the first click outside)
3952
- `Dialog` no longer supports `maxWidth` (it's now always `100%` - use `width`)
4053
- `Drawer` no longer supports `height` (use `minHeight`)
32.2 KB
Loading
33.3 KB
Loading
33.4 KB
Loading
2.8 KB
Loading
13.3 KB
Loading
32.5 KB
Loading
33.3 KB
Loading
32.7 KB
Loading

0 commit comments

Comments
 (0)