Color Wheel Optimizations (#40)

Author: dbchristopher

CHANGELOG.md

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Refactor z-index out of menu styles
 - Improvements to documentation layout and scrolling behavior
 - SVG for `ApplicationSelect`,`ArrowChange`,`Beaker`,`BrowseTable`,`ChangeHistory`,`DimensionFill`,`Explore`,`LogoRings`,`NoteOutline`,`Notes`,`Reports`,`SqlRunner`,`User`,`UserAttributes`,`Users`,`ViewGrid`,`VisArea`,`VisBar`,`VisColumn`,`VisLine`,`VisMap`,`VisPie`,`VisScatter`,`VisSingleValue`,`VisTable` icons resized redrawn to fit on the correct icon grid.
+- Optimize ColorWheel value change performance
+- Restore ColorWheel documentation
 - Implement a vertical layout for the Code Sandbox toolbar to prevent unintentional obfuscation of code samples
 
 ## [0.7.2] - 2019-11-11

jest.setup.js

@@ -3,17 +3,17 @@
  MIT License
 
  Copyright (c) 2019 Looker Data Sciences, Inc.
- 
+
  Permission is hereby granted, free of charge, to any person obtaining a copy
  of this software and associated documentation files (the "Software"), to deal
  in the Software without restriction, including without limitation the rights
  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  copies of the Software, and to permit persons to whom the Software is
  furnished to do so, subject to the following conditions:
- 
+
  The above copyright notice and this permission notice shall be included in all
  copies or substantial portions of the Software.
- 
+
  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -27,6 +27,7 @@
 const Adapter = require('enzyme-adapter-react-16')
 const Enzyme = require('enzyme')
 require('@testing-library/jest-dom/extend-expect')
+require('jest-canvas-mock')
 
 Enzyme.configure({ adapter: new Adapter() })
 

package.json

@@ -72,6 +72,7 @@
     "eslint-plugin-react-hooks": "^2.1.2",
     "eslint-plugin-standard": "^4.0.1",
     "jest": "^24.7.1",
+    "jest-canvas-mock": "^2.2.0",
     "jest-styled-components": "^6.3.3",
     "lerna": "^3.18.4",
     "lint-staged": "^9.2.5",

packages/components/src/Form/Fields/FieldColor/ColorWheel/ColorWheel.test.tsx

@@ -24,19 +24,46 @@
 
  */
 
-import 'jest-styled-components'
+import { render, fireEvent } from '@testing-library/react'
 import React from 'react'
-import { assertSnapshot } from '@looker/components-test-utils'
 import { ColorWheel } from './ColorWheel'
 
-test('Color wheel default ', () => {
-  assertSnapshot(<ColorWheel />)
-})
+test('ColorWheel updates color on click', async () => {
+  const handleColorChange = jest.fn()
+  const { findByTestId } = render(
+    <ColorWheel
+      hue={260}
+      saturation={0.5}
+      value={1}
+      size={400}
+      onColorChange={handleColorChange}
+    />
+  )
 
-test('Color wheel with h, s, v defined ', () => {
-  assertSnapshot(<ColorWheel hue={260} saturation={0.5} value={1} />)
-})
+  expect(handleColorChange).not.toHaveBeenCalled()
+
+  const mouseMarkerCanvas = await findByTestId('mouse-marker')
+  expect(mouseMarkerCanvas).toBeInTheDocument()
+
+  fireEvent(
+    mouseMarkerCanvas,
+    new MouseEvent('mousedown', {
+      bubbles: true,
+      cancelable: true,
+      clientX: 20,
+      clientY: 20,
+    })
+  )
+
+  fireEvent(
+    mouseMarkerCanvas,
+    new MouseEvent('mousedown', {
+      bubbles: true,
+      cancelable: true,
+      clientX: 300,
+      clientY: 300,
+    })
+  )
 
-test('Color wheel with h, s, v, size defined ', () => {
-  assertSnapshot(<ColorWheel hue={260} saturation={0.5} value={1} size={400} />)
+  expect(handleColorChange.mock.calls).toMatchSnapshot()
 })