Skip to content

Commit 7436717

Browse files
author
Luke Bowerman
authored
Added image-snapshot coverage for Tree (#1498)
* Added snapshot coverage for Tree * Minor fixes to README
1 parent 2d8f9f5 commit 7436717

File tree

14 files changed

+171
-92
lines changed

14 files changed

+171
-92
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
* Preview: `ActionListControls` component (this component is not yet ready for general-use)
1515
* Experimental: `@looker/components-theme-editor` package
1616
* Experimental: "Semantic" Layout components - `Layout`, `Header`, `Footer`, `Aside`
17-
- Implemented image snapshot support and added coverage for `Button*`, `IconButton` components
17+
18+
- Implemented image snapshot support and added coverage for `Button*`, `IconButton` & `Tree` components
1819
- Preliminary infrastructure for Storybook composition
1920
- Added support for Storybook extract behavior to improve published-Storybook performance
2021

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ We recommend using [Node Version Manager (NVM)](https://github.com/nvm-sh/nvm#in
6262

6363
#### Storybook
6464

65-
Storybook is a tool we use develop, demonstrate and document components in isolation.
65+
Storybook is a tool used to develop, demonstrate and document components in isolation.
6666

6767
- **yarn storybook** starts master Storybook (includes all stories)
6868
- **yarn workspace [workspace-package-name] storybook** starts a storybook with just stories within the specified package.
6969
- **yarn image-snapshots** takes image-snapshots of all stories within packages/\*\*
7070
- `preimage-snapshots` is a yarn task that runs `storybooks-build` task before capturing image snapshots.
71-
- **storybooks-build** builds all packages/\* storybooks for publishing and/or image-snapshot testing.
71+
- **yarn storybooks-build** builds all packages/\* storybooks for publishing and/or image-snapshot testing.
7272

7373
### Workspace Commands
7474

9.42 KB
Loading
6.85 KB
Loading
9.55 KB
Loading
11.1 KB
Loading
1.28 KB
Loading
22 KB
Loading
5.95 KB
Loading
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
/*
2+
3+
MIT License
4+
5+
Copyright (c) 2020 Looker Data Sciences, Inc.
6+
7+
Permission is hereby granted, free of charge, to any person obtaining a copy
8+
of this software and associated documentation files (the "Software"), to deal
9+
in the Software without restriction, including without limitation the rights
10+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11+
copies of the Software, and to permit persons to whom the Software is
12+
furnished to do so, subject to the following conditions:
13+
14+
The above copyright notice and this permission notice shall be included in all
15+
copies or substantial portions of the Software.
16+
17+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23+
SOFTWARE.
24+
25+
*/
26+
27+
import React from 'react'
28+
import styled from 'styled-components'
29+
import { AccordionDisclosureStyle } from '../..'
30+
import { TreeItem, Tree, TreeItemLabel } from '..'
31+
32+
export const BorderRadiusOverride = () => (
33+
<BorderRadiusOverrideTree label="Created" defaultOpen>
34+
<TreeItem>Created Date</TreeItem>
35+
<TreeItem>Created Month</TreeItem>
36+
<TreeItem>Created Year</TreeItem>
37+
<TreeItem>Created Quarter</TreeItem>
38+
</BorderRadiusOverrideTree>
39+
)
40+
41+
const BorderRadiusOverrideTree = styled(Tree)`
42+
${AccordionDisclosureStyle}, ${TreeItemLabel} {
43+
background: ${({ theme }) => theme.colors.ui2};
44+
border-radius: ${({ theme }) => theme.radii.medium};
45+
}
46+
`

0 commit comments

Comments
 (0)