Upgrade @looker/eslint-config dependency (#659)

Deal with related lint tweaks and fixes
Add `tsconfig.json` for eslint in www package (Gatsby's ESLint)

Author: Luke Bowerman

package.json

@@ -51,7 +51,7 @@
     "@babel/preset-react": "7.8.3",
     "@babel/preset-typescript": "^7.8.3",
     "@babel/runtime": "^7.8.7",
-    "@looker/eslint-config": "^1.0.7",
+    "@looker/eslint-config": "^1.0.11",
     "@looker/prettier-config": "^1.0.6",
     "@testing-library/jest-dom": "^5.1.1",
     "@testing-library/react": "^9.5.0",

packages/components/src/Button/ButtonSet.tsx

@@ -109,7 +109,7 @@ export const ButtonSet = forwardRef(
           ? {
               selected: isToggle
                 ? value === childValue
-                : value.indexOf(childValue) > -1,
+                : value.includes(childValue),
             }
           : { selected: childProps.selected }),
         ...(disabled ? { disabled } : {}),

packages/components/src/Calendar/CalendarNav.test.tsx

@@ -35,10 +35,12 @@ import { CalendarNav } from './CalendarNav'
 const realDateNow = Date.now.bind(global.Date)
 
 beforeEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = jest.fn(() => 1580517818172)
 })
 
 afterEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = realDateNow // reset Date.now mock
   jest.clearAllMocks()
 })

packages/components/src/Form/Fields/FieldColor/utils/color_format_utils.ts

@@ -179,6 +179,7 @@ export const toFormattedColorString = (
 ): string => {
   const color = d3color.color(value)
   if (!color) return ''
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   if (!color.displayable) return ''
 
   if (format === null) format = recognize(value)

packages/components/src/Form/Inputs/Combobox/ComboboxMultiInput.tsx

@@ -90,8 +90,8 @@ export const ComboboxMultiInputInternal = forwardRef(
     function handleChange(values: string[]) {
       transition &&
         transition(ComboboxActionType.CHANGE_VALUES, { inputValues: values })
-      const newOptions = options.filter(
-        option => values.indexOf(getComboboxText(option)) > -1
+      const newOptions = options.filter(option =>
+        values.includes(getComboboxText(option))
       )
       contextOnChange && contextOnChange(newOptions)
     }

packages/components/src/Form/Inputs/Combobox/ComboboxOption.tsx

@@ -231,7 +231,7 @@ export function ComboboxOptionTextInternal({
     inputValue === '' ||
     // inputValue is reflecting a currently selected option
     // highlighting it would be weird
-    (text === inputValue && optionTexts.indexOf(text) > -1)
+    (text === inputValue && optionTexts.includes(text))
   ) {
     return <span {...props}>{text}</span>
   }

packages/components/src/Form/Inputs/Combobox/utils/state.ts

@@ -294,7 +294,7 @@ const reducerMulti: Reducer<
         options: nextState.options.filter(
           option =>
             action.inputValues &&
-            action.inputValues.indexOf(getComboboxText(option)) > -1
+            action.inputValues.includes(getComboboxText(option))
         ),
       }
     case ComboboxActionType.NAVIGATE:

packages/components/src/Form/Inputs/InputChips/InputChips.tsx

@@ -104,7 +104,7 @@ export const InputChipsInternal = forwardRef(
         validValues,
       } = getUpdatedValues(
         // TypeScript can't tell that inputValue won't be undefined
-        newInputValue || (inputValue as string),
+        newInputValue || inputValue,
         values,
         validate
       )
@@ -149,7 +149,7 @@ export const InputChipsInternal = forwardRef(
       // If the last character is a comma, update the values
       // Or, if the user pastes content, we assume that the final value is complete
       // even if there's no comma at the end
-      if (isPasting.current || value[value.length - 1] === ',') {
+      if (isPasting.current || value.endsWith(',')) {
         updateValues(value)
         isPasting.current = false
       } else {

packages/components/src/Form/Inputs/InputDate/InputDate.test.tsx

@@ -33,10 +33,12 @@ import { InputDate } from './InputDate'
 const realDateNow = Date.now.bind(global.Date)
 
 beforeEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = jest.fn(() => 1580517818172)
 })
 
 afterEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = realDateNow // reset Date.now mock
   jest.clearAllMocks()
 })

packages/components/src/Form/Inputs/InputDateRange/InputDateRange.test.tsx

@@ -33,10 +33,12 @@ import { InputDateRange } from './InputDateRange'
 const realDateNow = Date.now.bind(global.Date)
 
 beforeEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = jest.fn(() => 1580517818172)
 })
 
 afterEach(() => {
+  /* eslint-disable-next-line @typescript-eslint/unbound-method */
   global.Date.now = realDateNow // reset Date.now mock
   jest.clearAllMocks()
 })