Skip to content

Commit 7d1be9a

Browse files
authored
Remove aria-labelledby on MenuList used without Menu (#389)
1 parent be70bd9 commit 7d1be9a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [UNRELEASE]
9+
10+
### Added
11+
12+
### Changes
13+
14+
### Fixed
15+
16+
- Bad `aria-labelledby` attribute on `MenuList` when used without `Menu`.
17+
818
## [0.7.11] - 2020-01-09
919

1020
### Added

packages/components/src/Menu/MenuList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const MenuListInternal = forwardRef(
115115
tabIndex={-1}
116116
role="menu"
117117
id={id}
118-
aria-labelledby={`button-${id}`}
118+
aria-labelledby={id && `button-${id}`}
119119
{...props}
120120
>
121121
{children}

0 commit comments

Comments
 (0)