Skip to content

Commit b611cb8

Browse files
author
Luke Bowerman
authored
Revert Space flex-shrink: 0 (#1559)
1 parent fe2070d commit b611cb8

File tree

4 files changed

+2
-35
lines changed

4 files changed

+2
-35
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [0.9.18] - 2020-10-12
8+
## [UNRELEASED]
99

1010
- `useDialog` needs to support scenario it is controlled but `onClose` isn't specified
11+
- `Space` revert mistakenly applied `flex-shrink: 0`
1112

1213
## [0.9.17] - 2020-10-12
1314

packages/components/src/Dialog/Layout/__snapshots__/DialogFooter.test.tsx.snap

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ exports[`DialogFooter with Button 1`] = `
1919
-webkit-flex-direction: row-reverse;
2020
-ms-flex-direction: row-reverse;
2121
flex-direction: row-reverse;
22-
-webkit-flex-shrink: 0;
23-
-ms-flex-negative: 0;
24-
flex-shrink: 0;
2522
-webkit-box-pack: justify;
2623
-webkit-justify-content: space-between;
2724
-ms-flex-pack: justify;
@@ -42,9 +39,6 @@ exports[`DialogFooter with Button 1`] = `
4239
-webkit-flex-direction: row-reverse;
4340
-ms-flex-direction: row-reverse;
4441
flex-direction: row-reverse;
45-
-webkit-flex-shrink: 0;
46-
-ms-flex-negative: 0;
47-
flex-shrink: 0;
4842
}
4943
5044
.c1 {
@@ -113,9 +107,6 @@ exports[`DialogFooter with DialogContext 1`] = `
113107
-webkit-flex-direction: row-reverse;
114108
-ms-flex-direction: row-reverse;
115109
flex-direction: row-reverse;
116-
-webkit-flex-shrink: 0;
117-
-ms-flex-negative: 0;
118-
flex-shrink: 0;
119110
-webkit-box-pack: justify;
120111
-webkit-justify-content: space-between;
121112
-ms-flex-pack: justify;
@@ -136,9 +127,6 @@ exports[`DialogFooter with DialogContext 1`] = `
136127
-webkit-flex-direction: row-reverse;
137128
-ms-flex-direction: row-reverse;
138129
flex-direction: row-reverse;
139-
-webkit-flex-shrink: 0;
140-
-ms-flex-negative: 0;
141-
flex-shrink: 0;
142130
}
143131
144132
.c1 {

packages/components/src/Layout/Space/Space.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ export const Space = styled.div<SpaceHelperProps>`
142142
${spaceCSS}
143143
${({ stretch }) => !stretch && verticalAlign}
144144
flex-direction: ${({ reverse }) => (reverse ? 'row-reverse' : 'row')};
145-
flex-shrink: 0;
146145
147146
${({ around }) => around && 'justify-content: space-around;'}
148147
${({ between }) => between && 'justify-content: space-between;'}

packages/components/src/Layout/Space/__snapshots__/Space.test.tsx.snap

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ exports[`Space around + gap (all you get is around) 1`] = `
1515
-webkit-flex-direction: row;
1616
-ms-flex-direction: row;
1717
flex-direction: row;
18-
-webkit-flex-shrink: 0;
19-
-ms-flex-negative: 0;
20-
flex-shrink: 0;
2118
-webkit-box-pack: space-around;
2219
-webkit-justify-content: space-around;
2320
-ms-flex-pack: space-around;
@@ -58,9 +55,6 @@ exports[`Space around 1`] = `
5855
-webkit-flex-direction: row;
5956
-ms-flex-direction: row;
6057
flex-direction: row;
61-
-webkit-flex-shrink: 0;
62-
-ms-flex-negative: 0;
63-
flex-shrink: 0;
6458
-webkit-box-pack: space-around;
6559
-webkit-justify-content: space-around;
6660
-ms-flex-pack: space-around;
@@ -101,9 +95,6 @@ exports[`Space between 1`] = `
10195
-webkit-flex-direction: row;
10296
-ms-flex-direction: row;
10397
flex-direction: row;
104-
-webkit-flex-shrink: 0;
105-
-ms-flex-negative: 0;
106-
flex-shrink: 0;
10798
-webkit-box-pack: justify;
10899
-webkit-justify-content: space-between;
109100
-ms-flex-pack: justify;
@@ -144,9 +135,6 @@ exports[`Space default 1`] = `
144135
-webkit-flex-direction: row;
145136
-ms-flex-direction: row;
146137
flex-direction: row;
147-
-webkit-flex-shrink: 0;
148-
-ms-flex-negative: 0;
149-
flex-shrink: 0;
150138
}
151139
152140
@supports (-moz-appearance:none) {
@@ -209,9 +197,6 @@ exports[`Space evenly 1`] = `
209197
-webkit-flex-direction: row;
210198
-ms-flex-direction: row;
211199
flex-direction: row;
212-
-webkit-flex-shrink: 0;
213-
-ms-flex-negative: 0;
214-
flex-shrink: 0;
215200
-webkit-box-pack: space-evenly;
216201
-webkit-justify-content: space-evenly;
217202
-ms-flex-pack: space-evenly;
@@ -252,9 +237,6 @@ exports[`Space reversed 1`] = `
252237
-webkit-flex-direction: row-reverse;
253238
-ms-flex-direction: row-reverse;
254239
flex-direction: row-reverse;
255-
-webkit-flex-shrink: 0;
256-
-ms-flex-negative: 0;
257-
flex-shrink: 0;
258240
}
259241
260242
@supports (-moz-appearance:none) {
@@ -317,9 +299,6 @@ exports[`Space with specified gap 1`] = `
317299
-webkit-flex-direction: row;
318300
-ms-flex-direction: row;
319301
flex-direction: row;
320-
-webkit-flex-shrink: 0;
321-
-ms-flex-negative: 0;
322-
flex-shrink: 0;
323302
}
324303
325304
@supports (-moz-appearance:none) {

0 commit comments

Comments
 (0)