Skip to content

Commit cbe4909

Browse files
committed
Add Popovers Testing page to playground
1 parent 0f21bc0 commit cbe4909

File tree

3 files changed

+73
-2
lines changed

3 files changed

+73
-2
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [UNRELEASED]
9+
10+
### Fixed
11+
12+
- `usePopover` issue where the next click after a popover closes is canceled – _actual fix_
13+
814
## [0.7.21] - 2020-02-26
915

1016
### Fixed
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
/*
2+
3+
MIT License
4+
5+
Copyright (c) 2019 Looker Data Sciences, Inc.
6+
7+
Permission is hereby granted, free of charge, to any person obtaining a copy
8+
of this software and associated documentation files (the "Software"), to deal
9+
in the Software without restriction, including without limitation the rights
10+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11+
copies of the Software, and to permit persons to whom the Software is
12+
furnished to do so, subject to the following conditions:
13+
14+
The above copyright notice and this permission notice shall be included in all
15+
copies or substantial portions of the Software.
16+
17+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23+
SOFTWARE.
24+
25+
*/
26+
27+
import React from 'react'
28+
import {
29+
Box,
30+
Button,
31+
DialogManager,
32+
Menu,
33+
MenuDisclosure,
34+
MenuList,
35+
MenuItem,
36+
ModalContent,
37+
Paragraph,
38+
} from '@looker/components'
39+
40+
export function TestPopovers() {
41+
function openAlert() {
42+
alert(`It's working!`)
43+
}
44+
return (
45+
<Box m="large">
46+
<Menu>
47+
<MenuDisclosure tooltip="Select your favorite kind">
48+
<Button mb="large">Open Menu</Button>
49+
</MenuDisclosure>
50+
<MenuList>
51+
<DialogManager
52+
content={
53+
<ModalContent>
54+
<Paragraph>Some content inside the Dialog</Paragraph>
55+
<Button onClick={openAlert}>Open Alert</Button>
56+
</ModalContent>
57+
}
58+
>
59+
{onClick => <MenuItem onClick={onClick}>Open Modal</MenuItem>}
60+
</DialogManager>
61+
</MenuList>
62+
</Menu>
63+
</Box>
64+
)
65+
}

packages/playground/src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ import { GlobalStyle } from '@looker/components'
2424
import { theme } from '@looker/design-tokens'
2525
import { ThemeProvider } from 'styled-components'
2626

27-
import { SelectDemo } from './Select/SelectDemo'
27+
import { TestPopovers } from './Popovers/Testing'
2828

2929
const App: React.FC = () => {
3030
return (
3131
<ThemeProvider theme={theme}>
3232
<GlobalStyle />
33-
<SelectDemo />
33+
<TestPopovers />
3434
</ThemeProvider>
3535
)
3636
}

0 commit comments

Comments
 (0)