Merge pull request #1105 from strongloop/newInstance_updateAttributes_2.x

Add 'isNewInstance' for updateAttributes

Author: Amir-61

lib/dao.js

@@ -571,6 +571,7 @@ DataAccessObject.upsert = function(data, options, cb) {
           var context = {
             Model: Model,
             data: data,
+            isNewInstance: info && info.isNewInstance,
             hookState: ctx.hookState,
             options: options,
           };
@@ -3100,6 +3101,7 @@ function(data, options, cb) {
                 data: context.data,
                 hookState: hookState,
                 options: options,
+                isNewInstance: false,
               };
               Model.notifyObserversOf('loaded', ctx, function(err) {
                 if (err) return cb(err);

test/memory.test.js

@@ -880,6 +880,7 @@ describe('Unoptimized connector', function() {
   // disable optimized methods
   ds.connector.updateOrCreate = false;
   ds.connector.findOrCreate = false;
+  ds.connector.upsertWithWhere = false;
 
   require('./persistence-hooks.suite')(ds, should, {
     replaceOrCreateReportsNewInstance: true,

test/persistence-hooks.suite.js

@@ -1356,6 +1356,7 @@ module.exports = function(dataSource, should, connectorCapabilities) {
 
           ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
             data: { name: 'changed' },
+            isNewInstance: false,
           }));
 
           done();
@@ -2010,19 +2011,13 @@ module.exports = function(dataSource, should, connectorCapabilities) {
           function(err, instance) {
             if (err) return done(err);
 
-            if (dataSource.connector.updateOrCreate) {
-              ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
-                data: { id: 'new-id', name: 'a name' },
-              }));
-            } else {
-              ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
-                data: {
-                  id: 'new-id',
-                  name: 'a name',
-                },
-                isNewInstance: true,
-              }));
-            }
+            ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
+              data: {
+                id: 'new-id',
+                name: 'a name',
+              },
+              isNewInstance: true,
+            }));
             done();
           });
       });
@@ -2034,24 +2029,13 @@ module.exports = function(dataSource, should, connectorCapabilities) {
           { id: existingInstance.id, name: 'updated name' },
           function(err, instance) {
             if (err) return done(err);
-
-            if (dataSource.connector.updateOrCreate) {
-              ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
-                data: {
-                  id: existingInstance.id,
-                  name: 'updated name',
-                },
-              }));
-            } else {
-              ctxRecorder.records.should.eql(
-                aCtxForModel(TestModel, {
-                  data: {
-                    id: existingInstance.id,
-                    name: 'updated name',
-                  },
-                })
-              );
-            }
+            ctxRecorder.records.should.eql(aCtxForModel(TestModel, {
+              data: {
+                id: existingInstance.id,
+                name: 'updated name',
+              },
+              isNewInstance: false,
+            }));
             done();
           });
       });
@@ -3259,13 +3243,8 @@ module.exports = function(dataSource, should, connectorCapabilities) {
                 id: existingInstance.id,
                 name: 'updated name',
               },
+              isNewInstance: false,
             });
-            // For non-atomic implementation of upsertWithWhere on update, it calls
-            // updateAttributes. loaded hook of updateAttributes does not provide
-            // isNewInstance.
-            if (dataSource.connector.upsertWithWhere) {
-              expectedContext.isNewInstance = false;
-            }
             ctxRecorder.records.should.eql(aCtxForModel(TestModel, expectedContext));
             done();
           });