Skip to content

Commit d818168

Browse files
authored
Merge pull request #1063 from strongloop/cleanup/memory-test
test/memory: remove dummy findOrCreate impl
2 parents 4ce8f97 + 6d3ea21 commit d818168

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

test/memory.test.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -871,26 +871,21 @@ describe('Memory connector', function() {
871871
describe('Optimized connector', function() {
872872
var ds = new DataSource({connector: Memory});
873873

874-
// optimized methods
875-
ds.connector.findOrCreate = function(model, query, data, callback) {
876-
this.all(model, query, {}, function(err, list) {
877-
if (err || (list && list[0])) return callback(err, list && list[0], false);
878-
this.create(model, data, {}, function(err) {
879-
callback(err, data, true);
880-
});
881-
}.bind(this));
882-
};
883-
884-
require('./persistence-hooks.suite')(ds, should, {replaceOrCreateReportsNewInstance: true});
874+
require('./persistence-hooks.suite')(ds, should, {
875+
replaceOrCreateReportsNewInstance: true,
876+
});
885877
});
886878

887879
describe('Unoptimized connector', function() {
888880
var ds = new DataSource({connector: Memory});
881+
889882
// disable optimized methods
890883
ds.connector.updateOrCreate = false;
891884
ds.connector.findOrCreate = false;
892885

893-
require('./persistence-hooks.suite')(ds, should, {replaceOrCreateReportsNewInstance: true});
886+
require('./persistence-hooks.suite')(ds, should, {
887+
replaceOrCreateReportsNewInstance: true,
888+
});
894889
});
895890

896891
describe('Memory connector with options', function() {

0 commit comments

Comments
 (0)