feat: adding option to disable server pretty formatting

Signed-off-by: Natan Carvalho <[email protected]>

Author: Natan Carvalho

src/base.js

@@ -66,6 +66,7 @@ class Base extends EventEmitter {
     this.wsdl.options.attributesKey = options.attributesKey || 'attributes';
     this.wsdl.options.envelopeKey = options.envelopeKey || 'soap';
     this.wsdl.options.forceSoapVersion = options.forceSoapVersion;
+    this.wsdl.options.prettyResponse = options.prettyResponse !== undefined ? options.prettyResponse : true;
   }
 
   static createSOAPEnvelope(prefix, nsURI) {

src/server.js

@@ -325,8 +325,8 @@ class Server extends Base {
       self.xmlHandler.jsonToXml(envelope.body, nsContext, outputBodyDescriptor, result);
 
       self._envelope(envelope, includeTimestamp);
-      var message = envelope.body.toString({pretty: true});
-      var xml = envelope.doc.end({pretty: true});
+      var message = envelope.body.toString({pretty: self.wsdl.options.prettyResponse});
+      var xml = envelope.doc.end({pretty: self.wsdl.options.prettyResponse});
 
       debug('Server handleResult. xml: %s ', xml);
       callback(xml);
@@ -423,9 +423,8 @@ class Server extends Base {
     this.xmlHandler.jsonToXml(envelope.body, nsContext, faultDescriptor, error.Fault);
 
     self._envelope(envelope, includeTimestamp);
-    var message = envelope.body.toString({pretty: true});
-    var xml = envelope.doc.end({pretty: true});
-
+    var message = envelope.body.toString({pretty: self.wsdl.options.prettyResponse});
+    var xml = envelope.doc.end({pretty: self.wsdl.options.prettyResponse});
     debug('Server sendError. Response envelope: %s ', xml);
     callback(xml, statusCode);
   }

test/server-test.js

@@ -498,3 +498,62 @@ it('should return a valid error if the server stops responding': function(done)
 */
 
 });
+
+describe('SOAP Server Options', function() {
+  before(function(done) {
+    fs.readFile(__dirname + '/wsdl/strict/stockquote.wsdl', 'utf8', function(err, data) {
+      assert.ok(!err);
+      test.wsdl = data;
+      done();
+    });
+  });
+
+  var startServer = function(optionsOverride) {
+    test.server = http.createServer(function(req, res) {
+      res.statusCode = 404;
+      res.end();
+    });
+
+    var options = {
+      path: '/stockquote',
+      services: test.service,
+      xml: test.wsdl,
+      ...optionsOverride
+    };
+
+    test.server.listen(15099, null, null, function() {
+      test.soapServer = soap.listen(test.server, options);
+      test.baseUrl =
+        'http://' + test.server.address().address + ":" + test.server.address().port;
+
+      //windows return 0.0.0.0 as address and that is not
+      //valid to use in a request
+      if (test.server.address().address === '0.0.0.0' || test.server.address().address === '::') {
+        test.baseUrl =
+          'http://127.0.0.1:' + test.server.address().port;
+      }
+    });
+  };
+
+  afterEach(function(done) {
+    test.server.close(function() {
+      test.server = null;
+      delete test.soapServer;
+      test.soapServer = null;
+      done();
+    });
+  });
+
+  it('should return response without newlines and white spaces', function(done) {
+    startServer({prettyResponse: false});
+    soap.createClient(test.baseUrl + '/stockquote?wsdl', function(err, client) {
+      assert.ok(!err);
+      var expectedBody = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/"><soap:Header/><soap:Body><ns1:TradePrice xmlns:ns1="http://example.com/stockquote.xsd"><price>19.56</price></ns1:TradePrice></soap:Body></soap:Envelope>';
+      client.GetLastTradePrice({TradePriceRequest: { tickerSymbol: 'AAPL'}}, function(err, res, body) {
+        assert.ok(!err);
+        assert.strictEqual(body.toString(), expectedBody);
+        done();
+      });
+    });
+  });
+});