dns/ddclient: move accounting of "last accessed timestamp' to poller, when execute() fails for whatever reason without an update, we want to prevent it looping to fast.

Author: AdSchellevis

dns/ddclient/src/opnsense/scripts/ddclient/lib/account/__init__.py

@@ -128,6 +128,5 @@ def execute(self):
             # if current address doesn't equal the current state, propagate the fact
             return True
         else:
-            # unmodified, keep track of last access timestamp
-            self._last_accessed = time.time()
+            # unmodified, poller keeps track of last access timestamp
             return False

dns/ddclient/src/opnsense/scripts/ddclient/lib/poller.py

@@ -151,6 +151,9 @@ def run(self):
                             if self.is_verbose:
                                 syslog.syslog(syslog.LOG_NOTICE, "Account %s changed" % acc.description)
                             needs_flush = True
+                        else:
+                            # update last accessed timestamp
+                            acc.update_state(None)
                     except Exception as e:
                         # fatal exception, update atime so we're not going to retry too soon
                         acc.update_state(None)