Skip to content

Commit 88f7191

Browse files
committed
Fix ARP audio stuttering on scroll.
1 parent ccb5ddf commit 88f7191

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

css/index.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,12 @@ footer {
6262
background-color: #353744;
6363
color: white;
6464
left: calc(50% - 510px);
65+
/*
66+
This Fixes a bad issue in Chrome when scrolling.
67+
The fixed position keyboard has to be re-rendered completely on scroll
68+
which causes notice-able stuttering in audio playback when ARP is on.
69+
*/
70+
transform: translate3d(0, 0, 0);
6571
}
6672

6773

src/App.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,18 @@ class App extends React.Component {
8888
<Keyboard
8989
eventEmitter={eventEmitter}
9090
Keyboard={this.props.Keyboard} />
91-
92-
<Synth
93-
store={this.props.store}
94-
eventEmitter={eventEmitter}
95-
audioContext={audioContext}
96-
Master={this.props.Master}
97-
Filter={this.props.Filter}
98-
Effects={this.props.Effects}
99-
Amp={this.props.Amp}
100-
Oscillators={this.props.Oscillators}
101-
LFOs={this.props.LFOs} />
10291
</footer>
92+
93+
<Synth
94+
store={this.props.store}
95+
eventEmitter={eventEmitter}
96+
audioContext={audioContext}
97+
Master={this.props.Master}
98+
Filter={this.props.Filter}
99+
Effects={this.props.Effects}
100+
Amp={this.props.Amp}
101+
Oscillators={this.props.Oscillators}
102+
LFOs={this.props.LFOs} />
103103
</div>
104104
</div>
105105
)

0 commit comments

Comments
 (0)