Merge pull request #7 from lopspower/feat_ktlint

[FEAT] Add ktlint

Author: lopspower

.editorconfig

@@ -0,0 +1,5 @@
+root = true
+[*.{kt,kts}]
+max_line_length = 120
+insert_final_newline = true
+disabled_rules = import-ordering, no-wildcard-imports

.github/pull_request_template.md

@@ -6,4 +6,17 @@ What types of changes does your code introduce?
 
 - [ ] Bugfix (non-breaking change which fixes an issue)
 - [ ] New feature (non-breaking change which adds functionality)
-- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+
+### Preparing a pull request for review
+Ensure your change is properly formatted by running:
+
+```gradle
+$ ./gradlew ktlintCheck
+```
+
+Please correct any failures before requesting a review by running:
+
+```gradle
+$ ./gradlew ktlintFormat
+```

build.gradle

@@ -17,6 +17,7 @@ buildscript {
 
 plugins {
     id "com.google.devtools.ksp" version "$kotlin_version-1.0.6"
+    id "org.jlleitschuh.gradle.ktlint" version "10.3.0"
 }
 
 apply from: 'dependencies.gradle'

data/build.gradle

@@ -3,6 +3,7 @@ plugins {
     id 'kotlin-android'
     id 'kotlinx-serialization'
     id 'com.google.devtools.ksp'
+    id 'org.jlleitschuh.gradle.ktlint'
     id 'com.github.ben-manes.versions'
     id 'com.adarshr.test-logger'
 }
@@ -34,6 +35,11 @@ android {
     }
 }
 
+ktlint {
+    verbose = true
+    android = true
+}
+
 dependencies {
     // MODULE
     implementation project(':domain')

data/src/androidTest/java/com/mikhaellopez/data/persistence/DatabaseFactoryTest.kt

@@ -10,5 +10,4 @@ object DatabaseFactoryTest {
             // allowing main thread queries, just for testing
             .allowMainThreadQueries()
             .build()
-
-}
+}

data/src/androidTest/java/com/mikhaellopez/data/persistence/dao/CardDaoTest.kt

@@ -137,11 +137,13 @@ open class CardDaoTest {
         assert(database.cardDao().insert(entity1) > 0)
         assert(database.cardDao().insert(entity2) > 0)
 
-        assert(database.cardDao().getAll().let {
-            it.size == 2
-                    && it[0].compareTo(entity1)
-                    && it[1].compareTo(entity2)
-        })
+        assert(
+            database.cardDao().getAll().let {
+                it.size == 2 &&
+                    it[0].compareTo(entity1) &&
+                    it[1].compareTo(entity2)
+            }
+        )
     }
 
     @Test
@@ -172,17 +174,16 @@ open class CardDaoTest {
 
     private fun CardEntity?.compareTo(entity: CardEntity): Boolean =
         this?.run {
-            name == entity.name
-                    && frenchName == entity.frenchName
-                    && japaneseName == entity.japaneseName
-                    && type == entity.type
-                    && rarity == entity.rarity
-                    && pokemonNumber == entity.pokemonNumber
-                    && picture == entity.picture
-                    && illustrator == entity.illustrator
-                    && wikiLink == entity.wikiLink
-                    && number == entity.number
-                    && isCheck == entity.isCheck
+            name == entity.name &&
+                frenchName == entity.frenchName &&
+                japaneseName == entity.japaneseName &&
+                type == entity.type &&
+                rarity == entity.rarity &&
+                pokemonNumber == entity.pokemonNumber &&
+                picture == entity.picture &&
+                illustrator == entity.illustrator &&
+                wikiLink == entity.wikiLink &&
+                number == entity.number &&
+                isCheck == entity.isCheck
         } ?: false
-
-}
+}

data/src/main/java/com/mikhaellopez/data/di/DataSourceModule.kt

@@ -36,4 +36,4 @@ val koinDataSourceModules = listOf(
     ProcessorModule().module,
     MapperModule().module,
     repositoryModule
-)
+)

data/src/main/java/com/mikhaellopez/data/di/MapperModule.kt

@@ -5,4 +5,4 @@ import org.koin.core.annotation.Module
 
 @Module
 @ComponentScan("com.mikhaellopez.data.mapper")
-class MapperModule
+class MapperModule

data/src/main/java/com/mikhaellopez/data/di/NetModule.kt

@@ -5,4 +5,4 @@ import org.koin.core.annotation.Module
 
 @Module
 @ComponentScan("com.mikhaellopez.data.net")
-class NetModule
+class NetModule

data/src/main/java/com/mikhaellopez/data/di/ProcessorModule.kt

@@ -5,4 +5,4 @@ import org.koin.core.annotation.Module
 
 @Module
 @ComponentScan("com.mikhaellopez.data.persistence.processor")
-class ProcessorModule
+class ProcessorModule