remove SelfBIndingResolver as one tests check that no automatic self binding happens; ensure that ConstructorScorer doesn't discard a constructor with ServiceKey attribute in favour of another constructor

Author: DominicUllmann

src/Ninject.Web.AspNetCore.ComplianceTest/KeyedDependencyInjectionComplianceTests.cs

@@ -1,5 +1,6 @@
 using System;
 using Microsoft.Extensions.DependencyInjection;
+using Ninject.Planning.Bindings.Resolvers;
 
 namespace Ninject.Web.AspNetCore.ComplianceTest;
 
@@ -13,6 +14,8 @@ public class KeyedDependencyInjectionComplianceTests : Microsoft.Extensions.Depe
 	protected override IServiceProvider CreateServiceProvider(IServiceCollection serviceCollection)
 	{
 		var kernel = new AspNetCoreKernel();
+		// remove autobinding as CreateServiceWithKeyedParameter e.g. tests that no autobinding happens.
+		kernel.Components.Remove<IMissingBindingResolver, SelfBindingResolver>();
 		var factory = new NinjectServiceProviderFactory(kernel);
 
 		return factory.CreateBuilder(serviceCollection).Build();

src/Ninject.Web.AspNetCore/Planning/ParameterTargetWithKeyedSupport.cs

@@ -13,6 +13,22 @@ public ParameterTargetWithKeyedSupport(MethodBase method, ParameterInfo site) :
 		{
 		}
 
+		public override bool HasDefaultValue
+		{
+			get
+			{
+				var result = this.Site.HasDefaultValue;
+#if NET8_0_OR_GREATER
+				// ensure that constructor scorer knows that we have a default value for parameters decorated with ServiceKey
+				// as the DefaultValueBindingResolver is only a MissingBindingResolver, the
+				// ParameterTargetWithKeyedSupport.ResolveWithin method already
+				// provided a default value before any Ninject resolution for the value happens.
+				result = result || GetCustomAttributes(typeof (ServiceKeyAttribute), true)?.Length > 0;
+#endif
+				return result;
+			}
+		}
+
 		protected override Func<IBindingMetadata, bool> ReadConstraintFromTarget()
 		{
 #if NET8_0_OR_GREATER